ci: Add additional ruff lint rules

[holtskinner]

No description provided.

[gemini-code-assist]

Summary of Changes

Hello @holtskinner, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses on enhancing the project's code quality and consistency by integrating a comprehensive set of new linting rules using Ruff. It expands the existing Ruff configuration to include checks for security, datetime handling, commented-out code, quote style, exception handling best practices, and performance anti-patterns. Additionally, the PR refines the format.sh script for more robust file detection and applies automatic fixes across the codebase to adhere to these new standards.

Highlights

• Expanded Ruff Linting Rules: A significant number of new rule sets have been enabled in .ruff.toml, including flake8-bandit (security), flake8-datetimez (timezone-aware datetimes), flake8-eradicate (commented-out code), flake8-quotes (quote style), flake8-raise (modern raise statements), tryceratops (exception handling), and perflint (performance anti-patterns).
• Refined Exception Handling Logging: Many instances of logger.error(f'...') within except Exception blocks have been updated to use logger.exception(...), which automatically includes traceback information, improving debugging capabilities.
• Improved Code Conciseness: Several traditional for loops for list population have been refactored into more Pythonic and concise list comprehensions.
• Stricter Type Annotation Checks: The allow-star-arg-any setting for flake8-annotations has been set to false, enforcing stricter type checking for *args and **kwargs.
• Enhanced Formatting Script: The scripts/format.sh script has been improved to use git ls-files for more reliable detection of Python files when formatting the entire repository, and its internal helper function for running formatters has been refined.
• Modernized Exception Raising: Instances of raising exceptions with empty parentheses (e.g., raise MyException()) have been updated to the more modern and efficient raise MyException.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in issue comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request enhances the project's linting capabilities by adding a comprehensive set of new ruff rules, including those for security, performance, and best practices. The subsequent code changes apply fixes for these new rules across the codebase. The changes are excellent, promoting better exception handling with logger.exception, adopting more Pythonic list comprehensions, and improving overall code consistency. My only suggestion is to fix the inconsistent indentation in the scripts/format.sh file to maintain a uniform style.