-
Notifications
You must be signed in to change notification settings - Fork 313
feat: Add custom ID generators to SimpleRequestContextBuilder #594
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add custom ID generators to SimpleRequestContextBuilder #594
Conversation
Summary of ChangesHello @chenweiyang0204, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request enhances the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request introduces a feature to allow custom ID generators for task and context IDs by updating SimpleRequestContextBuilder. The implementation is clean and correctly integrates with the existing RequestContext. My main feedback is that this new functionality is not covered by tests. I've added a comment to highlight the importance of adding tests to ensure the feature's correctness and prevent future regressions.
src/a2a/server/agent_execution/simple_request_context_builder.py
Outdated
Show resolved
Hide resolved
🤖 I have created a release *beep* *boop* --- ## [0.3.22](v0.3.21...v0.3.22) (2025-12-16) ### Features * Add custom ID generators to `SimpleRequestContextBuilder` ([#594](#594)) ([04bcafc](04bcafc)) ### Code Refactoring * Move agent card signature verification into `A2ACardResolver` ([6fa6a6c](6fa6a6c)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Description
This change allows passing custom
task_id_generatorandcontext_id_generatorfunctions to theSimpleRequestContextBuilder.This provides flexibility in how task and context IDs are generated, defaulting to the previous behavior if no generators are provided.
Thank you for opening a Pull Request!
Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
CONTRIBUTINGGuide.fix:which represents bug fixes, and correlates to a SemVer patch.feat:represents a new feature, and correlates to a SemVer minor.feat!:, orfix!:,refactor!:, etc., which represent a breaking change (indicated by the!) and will result in a SemVer major.bash scripts/format.shfrom the repository root to format)Fixes #<issue_number_goes_here> 🦕
Release-As: 0.3.22