Skip to content

Conversation

@chenweiyang0204
Copy link
Contributor

@chenweiyang0204 chenweiyang0204 commented Dec 15, 2025

Description

This change allows passing custom task_id_generator and context_id_generator functions to the SimpleRequestContextBuilder.

This provides flexibility in how task and context IDs are generated, defaulting to the previous behavior if no generators are provided.

Thank you for opening a Pull Request!
Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Follow the CONTRIBUTING Guide.
  • Make your Pull Request title in the https://www.conventionalcommits.org/ specification.
    • Important Prefixes for release-please:
      • fix: which represents bug fixes, and correlates to a SemVer patch.
      • feat: represents a new feature, and correlates to a SemVer minor.
      • feat!:, or fix!:, refactor!:, etc., which represent a breaking change (indicated by the !) and will result in a SemVer major.
  • Ensure the tests and linter pass (Run bash scripts/format.sh from the repository root to format)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> 🦕

Release-As: 0.3.22

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @chenweiyang0204, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request enhances the SimpleRequestContextBuilder by introducing the capability to inject custom ID generation functions for both tasks and contexts. This modification provides developers with increased flexibility in defining how these critical identifiers are created, allowing for tailored solutions without altering the core builder logic. The change maintains backward compatibility by defaulting to existing ID generation mechanisms when custom functions are not supplied.

Highlights

  • Custom ID Generators: The SimpleRequestContextBuilder now accepts optional task_id_generator and context_id_generator functions during its initialization.
  • Enhanced Flexibility: These new parameters allow for custom logic in generating task and context IDs, providing greater control over ID assignment.
  • Backward Compatibility: If no custom generators are provided, the system defaults to its previous ID generation behavior, ensuring no breaking changes.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a feature to allow custom ID generators for task and context IDs by updating SimpleRequestContextBuilder. The implementation is clean and correctly integrates with the existing RequestContext. My main feedback is that this new functionality is not covered by tests. I've added a comment to highlight the importance of adding tests to ensure the feature's correctness and prevent future regressions.

@chenweiyang0204 chenweiyang0204 marked this pull request as ready for review December 15, 2025 20:55
@chenweiyang0204 chenweiyang0204 requested a review from a team as a code owner December 15, 2025 20:55
@lkawka lkawka merged commit 04bcafc into a2aproject:main Dec 16, 2025
6 checks passed
sokoliva pushed a commit that referenced this pull request Dec 16, 2025
🤖 I have created a release *beep* *boop*
---


##
[0.3.22](v0.3.21...v0.3.22)
(2025-12-16)


### Features

* Add custom ID generators to `SimpleRequestContextBuilder`
([#594](#594))
([04bcafc](04bcafc))


### Code Refactoring

* Move agent card signature verification into `A2ACardResolver`
([6fa6a6c](6fa6a6c))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants