fix: fixing improper imports in starlette_app.py #78
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mindpower
approved these changes
May 21, 2025
martimfasantos
pushed a commit
to martimfasantos/a2a-python
that referenced
this pull request
May 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In current version of starlette_app.py,
RequestHandleris imported froma2a.server.request_handlers.jsonrpc_handler. Indeed it should be imported froma2a.server.request_handlers.request_handlerwhere it is defined. (It could also be from module via ini where it is mentioned. But, it's not the philosophy that seems used in this project)That's what this PR fixes. See commit diff for details.
CONTRIBUTINGGuide.nox -s formatfrom the repository root to format)