Skip to content

feat: bump react 18 and next #2271

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
foodaka wants to merge 5 commits into from
Closed

feat: bump react 18 and next #2271

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
87ca615
feat: bump react 18 and next
foodaka Nov 28, 2024
b88911d
feat: deps
foodaka Nov 28, 2024
11947b6
chore: fix lint issue
foodaka Nov 28, 2024
8109938
chore: bump next
foodaka Nov 28, 2024
c0bdce7
chore: bump next v
foodaka Nov 28, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,10 +78,10 @@
"immer": "^9.0.15",
"micro-memoize": "^4.1.2",
"mixpanel-browser": "^2.45.0",
"next": "12.1.1",
"react": "latest",
"next": "12.3.4",
"react": "^18.0.0",
"react-cookie-consent": "^8.0.1",
"react-dom": "latest",
"react-dom": "^18.0.0",
"react-infinite-scroller": "^1.2.6",
"react-lazy-load": "^4.0.1",
"react-markdown": "^8.0.7",
Expand Down
3 changes: 2 additions & 1 deletion src/components/Meta.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,9 +9,10 @@ type MetaProps = {
};

export function Meta({ title, description, imageUrl, timestamp }: MetaProps) {
const formattedTitle = `Aave - ${title}`;
return (
<Head>
<title>Aave - {title}</title>
<title>{formattedTitle}</title>{' '}
<meta name="description" content={description} key="description" />
<meta property="og:title" content={`Aave - ${title}`} key="title" />
<meta property="og:description" content={description} key="ogdescription" />
Expand Down
7 changes: 5 additions & 2 deletions src/components/primitives/Link.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,17 +4,20 @@ import clsx from 'clsx';
import NextLink, { LinkProps as NextLinkProps } from 'next/link';
import { useRouter } from 'next/router';
import * as React from 'react';
import { AnchorHTMLAttributes } from 'react';
import { CustomMarket } from 'src/ui-config/marketsConfig';

// Add support for the sx prop for consistency with the other branches.
const Anchor = styled('a')({});

interface NextLinkComposedProps
extends Omit<React.AnchorHTMLAttributes<HTMLAnchorElement>, 'href'>,
Omit<NextLinkProps, 'href' | 'as'> {
extends Omit<AnchorHTMLAttributes<HTMLAnchorElement>, 'href' | 'onClick' | 'onMouseEnter'>,
Omit<NextLinkProps, 'href' | 'as' | 'onClick' | 'onMouseEnter'> {
to: NextLinkProps['href'];
linkAs?: NextLinkProps['as'];
href?: NextLinkProps['href'];
onClick?: (event: React.MouseEvent<HTMLAnchorElement, MouseEvent>) => void;
onMouseEnter?: (event: React.MouseEvent<HTMLAnchorElement, MouseEvent>) => void;
}

export const NextLinkComposed = React.forwardRef<HTMLAnchorElement, NextLinkComposedProps>(
Expand Down
Loading
Loading