-
Notifications
You must be signed in to change notification settings - Fork 41
Release/1.3.0 #1156
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release/1.3.0 #1156
Conversation
WalkthroughBumps project version to 1.3.0 across docs, build properties, and a test expectation; adds a new 1.3.0 CHANGELOG entry mentioning LiveObjects. No code or public API changes. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Poem
Tip 🔌 Remote MCP (Model Context Protocol) integration is now available!Pro plan users can now connect to remote MCP servers from the Integrations page. Connect with popular remote MCPs such as Notion and Linear to add more context to your reviews and chats. 📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro 💡 Knowledge Base configuration:
You can enable these sources in your CodeRabbit configuration. 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (11)
✨ Finishing Touches🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR/Issue comments)Type Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (4)
lib/src/test/java/io/ably/lib/test/realtime/RealtimeHttpHeaderTest.java (1)
90-92: Tests correctly referenceVERSION_NAME; optional refactor to derive version from metadataAll checks confirm the test’s hard-coded version (
1.3.0) matchesgradle.properties. No blocking issues remain.• Optional refactor: replace the literal
"ably-java/1.3.0"with a lookup using your package’s implementation metadata, e.g.String version = YourClass.class.getPackage().getImplementationVersion(); assertEquals("Verify correct lib version", requestParameters.get("agent"), Collections.singletonList("ably-java/" + (version != null ? version : "1.3.0") + " jre/" + System.getProperty("java.version")));This keeps the test aligned automatically on each release.
CONTRIBUTING.md (1)
238-239: Use a variable placeholder for the AAR version in CONTRIBUTING.mdTo avoid having to update this example on every release, replace the hard-coded version with a placeholder—just like other docs:
• File: CONTRIBUTING.md, line 238
• Change the AAR reference to use${ABLY_VERSION}- implementation files('libs/ably-android-1.3.0.aar') + implementation files("libs/ably-android-${ABLY_VERSION}.aar")README.md (2)
145-145: OkHttp engine dependency updated to 1.3.0 — LGTMIf you plan to promote OkHttp usage more broadly, consider cross-linking to the section that explains swapping engines (already present in CONTRIBUTING).
116-116: Flag Live Objects as Experimental in READMEThe
liveobjectsmodule is correctly included and published:
settings.gradle.kts, line 18:include("liveobjects")gradle.properties, line 1:GROUP=io.ablyTo make its experimental status clear to users, add an inline comment in
README.md(line 116):- runtimeOnly("io.ably:liveobjects:1.3.0") + runtimeOnly("io.ably:liveobjects:1.3.0") // Experimental: API may change
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
💡 Knowledge Base configuration:
- MCP integration is disabled by default for public repositories
- Jira integration is disabled by default for public repositories
- Linear integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
📒 Files selected for processing (5)
CHANGELOG.md(1 hunks)CONTRIBUTING.md(1 hunks)README.md(3 hunks)gradle.properties(1 hunks)lib/src/test/java/io/ably/lib/test/realtime/RealtimeHttpHeaderTest.java(1 hunks)
🧰 Additional context used
🧠 Learnings (4)
📓 Common learnings
Learnt from: sacOO7
PR: ably/ably-java#1151
File: lib/src/main/java/io/ably/lib/objects/type/counter/LiveCounter.java:15-15
Timestamp: 2025-08-19T10:42:35.254Z
Learning: The ably-java library has not had any official releases yet, so breaking changes to public APIs (like adding new abstract methods to interfaces) are acceptable during the pre-release development phase.
📚 Learning: 2025-06-05T10:27:53.946Z
Learnt from: sacOO7
PR: ably/ably-java#1095
File: gradle/libs.versions.toml:24-26
Timestamp: 2025-06-05T10:27:53.946Z
Learning: The ably-java project prefers to use the latest available versions of testing dependencies (including pre-release versions) when they contain relevant bug fixes, rather than sticking strictly to stable releases.
Applied to files:
gradle.propertiesREADME.mdCHANGELOG.md
📚 Learning: 2025-08-19T10:42:35.254Z
Learnt from: sacOO7
PR: ably/ably-java#1151
File: lib/src/main/java/io/ably/lib/objects/type/counter/LiveCounter.java:15-15
Timestamp: 2025-08-19T10:42:35.254Z
Learning: The ably-java library has not had any official releases yet, so breaking changes to public APIs (like adding new abstract methods to interfaces) are acceptable during the pre-release development phase.
Applied to files:
README.mdCHANGELOG.md
📚 Learning: 2025-08-14T10:43:57.974Z
Learnt from: sacOO7
PR: ably/ably-java#1148
File: lib/src/main/java/io/ably/lib/objects/ObjectsHelper.java:24-25
Timestamp: 2025-08-14T10:43:57.974Z
Learning: In the ably-java LiveObjects renaming effort, log messages may intentionally retain "LiveObjects" terminology even when other parts of the codebase are being renamed to "Objects", due to internal technical debates about where the renaming should be applied. The team makes deliberate decisions about which parts of the codebase to rename versus which to keep as-is.
Applied to files:
CHANGELOG.md
🪛 markdownlint-cli2 (0.17.2)
README.md
58-58: Trailing punctuation in heading
Punctuation: ':'
(MD026, no-trailing-punctuation)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (12)
- GitHub Check: check (29)
- GitHub Check: build
- GitHub Check: check (24)
- GitHub Check: check-rest-okhttp
- GitHub Check: check (29)
- GitHub Check: check (21)
- GitHub Check: check-realtime-okhttp
- GitHub Check: check (19)
- GitHub Check: check-liveobjects
- GitHub Check: check
- GitHub Check: check-realtime
- GitHub Check: check-rest
🔇 Additional comments (4)
gradle.properties (1)
2-2: Version bump to 1.3.0 — no stale references remain
- Scanned for “1.2.54” across the repo (excluding build/**) and only historical entries were found in CHANGELOG.md, which are expected.
- Verified all code/tests/docs now reference “1.3.0” (e.g. RealtimeHttpHeaderTest.java line 91).
Everything’s in sync and ready for tagging.
CHANGELOG.md (1)
3-12: CHANGELOG.md compare link validated
- New 1.3.0 entry is clear, concise, and the compare link format has been confirmed in CHANGELOG.md (lines 3–12).
- Optional nit: for consistency with past entries, consider appending the release date to the heading (e.g., “## 1.3.0 – 2025-08-26”).
✅ No blockers.
README.md (2)
54-54: Maven coordinates bumped to 1.3.0 — LGTM
61-61: Gradle notation updated to 1.3.0 — LGTM
sacOO7
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
Do we also need liveobjects README similar to swift plugin? |
This release introduces experimental support for Live Objects, providing realtime, collaborative data structures that automatically synchronize state across all connected clients.
Implemented enhancements:
Summary by CodeRabbit