-
Notifications
You must be signed in to change notification settings - Fork 41
Adds getting started links #1159
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
WalkthroughDocs-only updates to README.md: reorganized sections, updated links, renamed headers, added a proxy setup collapsible block with OkHttp example, consolidated example references, and adjusted formatting. The CHANGELOG link is now relative, and an explicit instruction to run the example app was added. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Poem
Tip 🔌 Remote MCP (Model Context Protocol) integration is now available!Pro plan users can now connect to remote MCP servers from the Integrations page. Connect with popular remote MCPs such as Notion and Linear to add more context to your reviews and chats. ✨ Finishing Touches🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR/Issue comments)Type Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
README.md (1)
110-118: Fix README Live Objects dependency coordinate
io.ably:liveobjectsisn’t published on Maven Central. Replace theruntimeOnly("io.ably:liveobjects:1.2.54")entry with animplementationdependency using the actual Ably Java artifact (e.g.io.ably:ably-java:<latest-version>), and verify the correct version on Maven Central.
🧹 Nitpick comments (2)
README.md (2)
108-108: Subject–verb agreement in product sentence.Use singular verb form with the product name.
Apply:
-[Ably Live Objects](https://ably.com/docs/liveobjects) provide realtime, collaborative data structures... +[Ably Live Objects](https://ably.com/docs/liveobjects) provides realtime, collaborative data structures...
200-200: Relative CHANGELOG link: nice; minor style nit.Drop the extra “also” for tighter prose.
-The [CHANGELOG.md](./CHANGELOG.md) contains details of the latest releases for this SDK. You can also view all Ably releases on [changelog.ably.com](https://changelog.ably.com). +The [CHANGELOG.md](./CHANGELOG.md) contains details of the latest releases for this SDK. You can view all Ably releases on [changelog.ably.com](https://changelog.ably.com).
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
💡 Knowledge Base configuration:
- MCP integration is disabled by default for public repositories
- Jira integration is disabled by default for public repositories
- Linear integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
📒 Files selected for processing (1)
README.md(5 hunks)
🧰 Additional context used
🧠 Learnings (2)
📚 Learning: 2025-06-05T10:27:53.946Z
Learnt from: sacOO7
PR: ably/ably-java#1095
File: gradle/libs.versions.toml:24-26
Timestamp: 2025-06-05T10:27:53.946Z
Learning: The ably-java project prefers to use the latest available versions of testing dependencies (including pre-release versions) when they contain relevant bug fixes, rather than sticking strictly to stable releases.
Applied to files:
README.md
📚 Learning: 2025-08-19T10:42:35.254Z
Learnt from: sacOO7
PR: ably/ably-java#1151
File: lib/src/main/java/io/ably/lib/objects/type/counter/LiveCounter.java:15-15
Timestamp: 2025-08-19T10:42:35.254Z
Learning: The ably-java library has not had any official releases yet, so breaking changes to public APIs (like adding new abstract methods to interfaces) are acceptable during the pre-release development phase.
Applied to files:
README.md
🪛 LanguageTool
README.md
[style] ~200-~200: This adverb was used twice in the sentence. Consider removing one of them or replacing them with a synonym.
Context: ...so view all Ably releases on changelog.ably.com. --- ...
(ADVERB_REPETITION_PREMIUM)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (12)
- GitHub Check: check (21)
- GitHub Check: check (29)
- GitHub Check: check (24)
- GitHub Check: check (19)
- GitHub Check: check
- GitHub Check: check-realtime
- GitHub Check: build
- GitHub Check: check-rest-okhttp
- GitHub Check: check (29)
- GitHub Check: check-liveobjects
- GitHub Check: check-realtime-okhttp
- GitHub Check: check-rest
🔇 Additional comments (3)
README.md (3)
22-22: Good swap to canonical “Getting started” doc.Accurate and clearer entry point for new users.
120-123: Verified examples directory and README references:./examplesdirectory andexamples/README.mdare present, and the README includes both Color Voting and Task Management examples.
37-37: Apply spacing fix on Android row (minimum API 19 confirmed)
API level 19 (Android 4.4 KitKat) remains the supported minimum. Update spacing for consistency:-| Android | >=4.4 (API level 19) | +| Android | >= 4.4 (API level 19) |
sacOO7
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
ttypic
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This PR:
Summary by CodeRabbit