-
Notifications
You must be signed in to change notification settings - Fork 41
Release/1.4.0 #1166
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release/1.4.0 #1166
Conversation
WalkthroughVersion bumped from 1.3.0 to 1.4.0 across docs, build properties, and tests. CHANGELOG adds 1.4.0 notes. CONTRIBUTING and README dependency references updated to 1.4.0. gradle.properties VERSION_NAME set to 1.4.0. A unit test expected agent header string updated to reflect 1.4.0. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Poem
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches
🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
Disabled knowledge base sources:
- Jira integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
📒 Files selected for processing (5)
CHANGELOG.md(1 hunks)CONTRIBUTING.md(1 hunks)README.md(3 hunks)gradle.properties(1 hunks)lib/src/test/java/io/ably/lib/test/realtime/RealtimeHttpHeaderTest.java(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (12)
- GitHub Check: check-liveobjects
- GitHub Check: check-rest-okhttp
- GitHub Check: check-realtime-okhttp
- GitHub Check: check-realtime
- GitHub Check: check-rest
- GitHub Check: check (29)
- GitHub Check: check (24)
- GitHub Check: check (21)
- GitHub Check: check (19)
- GitHub Check: check
- GitHub Check: build
- GitHub Check: check (29)
🔇 Additional comments (4)
CONTRIBUTING.md (1)
238-238: Updated local AAR reference looks goodThanks for keeping the CONTRIBUTING instructions aligned with 1.4.0.
lib/src/test/java/io/ably/lib/test/realtime/RealtimeHttpHeaderTest.java (1)
90-92: Agent header assertion stays in lockstep with the releaseNice job updating the test expectation to 1.4.0 so the agent-header contract stays green with the new release.
README.md (1)
54-144: Version references updated accuratelyAll installation snippets now point to 1.4.0, keeping the docs aligned with the release.
CHANGELOG.md (1)
3-11: Changelog entry looks completeThe 1.4.0 section clearly lists the key PRs and comparison link—no issues spotted.
Release 1.4.0
Summary by CodeRabbit
New Features
Bug Fixes
Documentation
Tests
Chores