Fix: Remove a confusing rule that misidentified 'See LICENSE' text #4671
+0
−8
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The rule
unknown_10.RULEincorrectly flagged the text "See LICENSE file for details" asunknown-license-reference, causing false positives when scanning projects with valid license file references like node-cookie-signature.Investigation
unknown_10.RULEwas originally added in commitd2e482a41a(Aug 2017) for a specific APS extensions license patternaac03fc014(Mar 2021) to be more generic:"See LICENSE file for details"(with quotes)unknown-license-reference_see-license_1.RULEalready handle "See LICENSE" patterns correctly without requiring quotesSolution
Remove the problematic
unknown_10.RULEfile. The quoted version is not a standard pattern, and other existing rules properly handle legitimate "See LICENSE" references.Testing
✅ Verified that only the rule file is removed
✅ No test files are affected
✅ The change is focused and minimal
✅ Tested locally with node-cookie-signature v1.2.2 - no longer shows false positive
Related Issues
Fixes #4481
Related to #4387 (similar issue with same rule)
Signed-off-by: Jayant Saxena jayantmcom@gmail.com