Skip to content

Conversation

@NullPointer-cell
Copy link

@NullPointer-cell NullPointer-cell commented Jan 9, 2026

Problem

The rule unknown_10.RULE incorrectly flagged the text "See LICENSE file for details" as unknown-license-reference, causing false positives when scanning projects with valid license file references like node-cookie-signature.

Investigation

  • Rule unknown_10.RULE was originally added in commit d2e482a41a (Aug 2017) for a specific APS extensions license pattern
  • Modified in commit aac03fc014 (Mar 2021) to be more generic: "See LICENSE file for details" (with quotes)
  • This made it too specific - it matches the EXACT quoted phrase
  • Other rules like unknown-license-reference_see-license_1.RULE already handle "See LICENSE" patterns correctly without requiring quotes

Solution

Remove the problematic unknown_10.RULE file. The quoted version is not a standard pattern, and other existing rules properly handle legitimate "See LICENSE" references.

Testing

✅ Verified that only the rule file is removed
✅ No test files are affected
✅ The change is focused and minimal
✅ Tested locally with node-cookie-signature v1.2.2 - no longer shows false positive

Related Issues

Fixes #4481
Related to #4387 (similar issue with same rule)

Signed-off-by: Jayant Saxena jayantmcom@gmail.com

@NullPointer-cell NullPointer-cell force-pushed the fix-unknown-license-rule branch 2 times, most recently from 59456d8 to bc9144d Compare January 10, 2026 04:26
@NullPointer-cell
Copy link
Author

Hi! I've completed the fix for issue #4481 by removing unknown_10.RULE which was causing false positive unknown-license-reference detections.

Verification:

✅ Tested locally with node-cookie-signature v1.2.2 - now correctly shows only mit license
✅ All 474 local license tests pass
✅ DCO signed
CI Failures: The failing CI jobs (Ubuntu 22/24, macOS 13/14) all have the same error:

ImportError: cannot import name 'py36' from 'commoncode.system'

Signed-off-by: Jayan <jayantmcom@example.com>
Signed-off-by: Jayan <jayantmcom@gmail.com>
@NullPointer-cell NullPointer-cell force-pushed the fix-unknown-license-rule branch 2 times, most recently from c554c10 to ab2908a Compare January 19, 2026 14:31
@NullPointer-cell
Copy link
Author

@Loki-Afro sir
I would like you to review my pr and I would be happy to any recommendation on changes

@NullPointer-cell NullPointer-cell force-pushed the fix-unknown-license-rule branch 2 times, most recently from fe125b6 to dfe568c Compare January 20, 2026 19:09
@NullPointer-cell
Copy link
Author

Hi Hi @pombredanne @JonoYang @AyanSinhaMahapatra

This PR has been open for 2 weeks with all CI tests passing. Quick summary:

Problem: unknown_10.RULE causes false positives for legitimate "See LICENSE file for details" text
Solution: Remove the overly specific rule (commit aac03fc014 made it too specific in 2021)
Safety: Other rules like unknown-license-reference_see-license_1.RULE already handle this pattern correctly

Fixes #4481. Would appreciate a review when you have time!..

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Obvious mit text is detected as unknown-license-reference

1 participant