Fix issue 1875 scala case classes #1969
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ode-org#1957) - Modified resolve_pypi_packages() to accept multiple requirement files - Updated get_data_from_manifests() to batch-process PyPI manifests together - Maintained backward compatibility with existing single-file API - Added comprehensive tests for multiple files and backward compatibility This fix resolves issue aboutcode-org#1957 where the pipeline failed when multiple manifest files (e.g., requirements.txt in different subfolders) were present in a project. The solution leverages python-inspector's ability to process multiple requirement files in a single call, which is more efficient and provides better dependency resolution context. Fixes aboutcode-org#1957 Signed-off-by: pradhyum6144 <pradhyum314@gmail.com>
Signed-off-by: pradhyum6144 <pradhyum314@gmail.com>
In Scala, case classes and inner classes defined within sealed traits or objects compile to separate .class files that may not follow the standard himBHsseparated naming convention. This fix implements a fallback mechanism to handle these cases. Changes: - Added custom get_normalized_path() method to ScalaLanguage class - Enhanced _map_jvm_to_class_resource() with Scala-specific fallback that searches for source files in the same package directory when exact match is not found - Added comprehensive test case for Scala case class mapping Fixes aboutcode-org#1875 Signed-off-by: pradhyum6144 <pradhyum314@gmail.com>
pradhyum6144
force-pushed
the
fix-issue-1875-scala-case-classes
branch
from
df27a3d to
a522fab
Compare
Author
|
Hey @chinyeungli I've created a fix for this issue! I’d like you to review my code and accept it. |
Contributor
|
@tdruez perhaps you are in a better position for the review |
Signed-off-by: pradhyum6144 <pradhyum314@gmail.com>
pradhyum6144
force-pushed
the
fix-issue-1875-scala-case-classes
branch
from
4ec61ee to
955ac6c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
In Scala, case classes and inner classes defined within sealed traits or objects compile to separate .class files that may not follow the standard $-separated naming convention.
Solution
Implemented a fallback mechanism specifically for Scala that searches for source files in the same package directory when an exact match is not found.
Testing
All syntax checks passed
New test case covers the specific scenario described in issue #1875
Maintains backward compatibility with existing Java, Kotlin, and other JVM language mappings