Add a search bar for resource detail page on pressing Ctrl+K #2048
+79
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… resources upon pressing Ctrl+K or /. Fixes aboutcode-org#870 Signed-off-by: Daksh Jain <jain.daksh0808@gmail.com> Signed-off-by: Daksh Jain <jain.daksh0808@gmail.com>
Signed-off-by: Daksh Jain <jain.daksh0808@gmail.com>
Daksh-Jain08
force-pushed
the
feature/search-on-resource-detail
branch
from
3e1abc9 to
0106859
Compare
Author
|
@tdruez @AyanSinhaMahapatra Please review the changes and suggest improvments if any. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add a keyboard-activated search modal to the resource detail page, allowing users to quickly search resources without navigating back to the resource list.
Fixes #870
Changes
resource_search_modal.htmltemplate with a search formresource_detail.htmlfor opening the modalFeatures
Screenshot
Testing
Ctrl+Kor/to open the search modalEscto close the modal without searching