Conversation
Added almalinux advisories and tests for it Signed-off-by: ambuj <kulshreshthaak.12@gmail.com>
|
@ziadhany as this importer uses osv.py importer so shall I add AlmaLinux:8 and AlmaLinux:9 in supported ecosystems in osv.py |
|
@ambuj-1211 yes, you should add it to this |
Signed-off-by: ambuj <kulshreshthaak.12@gmail.com>
|
@ambuj-1211 but you will face another issue. you need to add support for almalinux in univers. |
Signed-off-by: ambuj <kulshreshthaak.12@gmail.com>
Signed-off-by: ambuj <kulshreshthaak.12@gmail.com>
Signed-off-by: ambuj <kulshreshthaak.12@gmail.com>
Signed-off-by: ambuj <kulshreshthaak.12@gmail.com>
Signed-off-by: ambuj <kulshreshthaak.12@gmail.com>
Signed-off-by: ambuj <kulshreshthaak.12@gmail.com>
|
@ziadhany can this be merged ? |
I still need to review this code |
…tion - Added a detailed docstring to the `parse_advisory_data` function in the `almalinux-importer` module. - The docstring includes a clear description of the function's purpose, arguments, return value, and an example usage. - Improved the readability and structure of the example output in the docstring to ensure clarity and consistency. This documentation enhancement makes the `parse_advisory_data` function easier to understand and use, aiding future development and maintenance. Signed-off-by: ambuj <kulshreshthaak.12@gmail.com>
ziadhany
left a comment
There was a problem hiding this comment.
Why not use the existing OSV script directly or modify it to support Almalinux, instead of rewriting the entire code?
|
@ambuj-1211 Update the OSV |
df053ba to
088279c
Compare
Signed-off-by: ambuj <kulshreshthaak.12@gmail.com>
Signed-off-by: ambuj <kulshreshthaak.12@gmail.com>
|
@ziadhany please have a look at it I have made the necessary changes |
ziadhany
left a comment
There was a problem hiding this comment.
Thanks! @ambuj-1211, the code looks good overall, just a few small nits. Please run the importer and share the logs.
Signed-off-by: ambuj <kulshreshthaak.12@gmail.com>
|
almalinux_logs.txt |
ziadhany
left a comment
There was a problem hiding this comment.
@ambuj-1211 LGTM , We can merge once you resolve the merge conflict.
|
@ziadhany I have resolved the merge conflicts |
|
@TG1999 @keshav-space @ziadhany please chack if it could be merged now? |
|
@ziadhany @TG1999 @keshav-space please have a look at it |
ziadhany
left a comment
There was a problem hiding this comment.
@ambuj-1211 The code looks perfect, but when I ran the importer I got an error related to AlmaLinux:10, so we should add it to the OSV list mapping.
Unsupported package type: {'package': {'ecosystem': 'AlmaLinux:10', 'name': 'firefox'}, 'ranges': [{'type': 'ECOSYSTEM', 'events': [{'introduced': '0'}, {'fixed': '128.13.0-1.el10_0'}]}]} in OSV: 'ALSA-2025:11797'
Unsupported package type: {'package': {'ecosystem': 'AlmaLinux:10', 'name': 'tomcat9'}, 'ranges': [{'type': 'ECOSYSTEM', 'events': [{'introduced': '0'}, {'fixed': '1:9.0.87-5.el10_0'}]}]} in OSV: 'ALSA-2025:7494'
Signed-off-by: ambuj <kulshreshthaak.12@gmail.com>
Signed-off-by: ambuj <kulshreshthaak.12@gmail.com>
|
@ziadhany done the changes |
|
@ambuj-1211 it would also be awesome if you have time to migrate this advisory to work with the importer v2 |
Fix #1201
@ziadhany @TG1999 @keshav-space This is the basic nit to adds Alma Linux advisories into vulnerablecode database, please review it to make further changes.