Skip to content

Fillup missing vulnerabilities summary#1767

Merged
TG1999 merged 7 commits intomainfrom
missing_summaries_pipeline
Apr 1, 2025
Merged

Fillup missing vulnerabilities summary#1767
TG1999 merged 7 commits intomainfrom
missing_summaries_pipeline

Conversation

@TG1999
Copy link
Contributor

@TG1999 TG1999 commented Jan 29, 2025 •
edited by pombredanne
Loading

Fixes: #859

@TG1999 TG1999 force-pushed the missing_summaries_pipeline branch from 9557b88 to f4140cd Compare February 11, 2025 14:09
pombredanne
pombredanne requested changes Feb 11, 2025
View reviewed changes
Copy link
Member

@pombredanne pombredanne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here are some feedback.

vulnerabilities/pipelines/fill_vulnerability_summary_pipeline.py Outdated
matching_advisories = nvd_importer_advisories.filter(Q(aliases__contains=alias))

if matching_advisories.exists():
# Take the first matching advisory with a summary
Copy link
Member

@pombredanne pombredanne Feb 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
# Take the first matching advisory with a summary
# Take the first matching advisory with a summary.
# NVD advisories only have one alias, always a CVE

keshav-space
keshav-space requested changes Feb 11, 2025
View reviewed changes
Copy link
Member

@keshav-space keshav-space left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @TG1999, few nits for your consideration.

@TG1999 TG1999 force-pushed the missing_summaries_pipeline branch from e11385d to 0ac0e67 Compare March 21, 2025 10:03
keshav-space
keshav-space requested changes Mar 21, 2025
View reviewed changes
Copy link
Member

@keshav-space keshav-space left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @TG1999, few nits for your consideration,

TG1999 added 6 commits March 27, 2025 13:40
@TG1999
Adress review comments
db52c5e 
Signed-off-by: Tushar Goel <tushar.goel.dav@gmail.com>
@TG1999
Add tests
01abf21 
Signed-off-by: Tushar Goel <tushar.goel.dav@gmail.com>
@TG1999
Address review comments
1cafd40 
Signed-off-by: Tushar Goel <tushar.goel.dav@gmail.com>
@TG1999
Change models
6328d93 
Signed-off-by: Tushar Goel <tushar.goel.dav@gmail.com>
@TG1999
Change models
97301bc 
Signed-off-by: Tushar Goel <tushar.goel.dav@gmail.com>
@TG1999
Adhere to new models for summary pipeline
2362056 
Signed-off-by: Tushar Goel <tushar.goel.dav@gmail.com>
@TG1999 TG1999 force-pushed the missing_summaries_pipeline branch from 0ac0e67 to 2362056 Compare March 31, 2025 07:16
@TG1999
Do bulk update
2ceb046 
Signed-off-by: Tushar Goel <tushar.goel.dav@gmail.com>
@TG1999 TG1999 merged commit 1f394fa into main Apr 1, 2025
10 checks passed
@TG1999 TG1999 deleted the missing_summaries_pipeline branch April 1, 2025 06:21
@TG1999 TG1999 mentioned this pull request Apr 1, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pombredanne pombredanne pombredanne requested changes

@keshav-space keshav-space keshav-space requested changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

VCIO-next: Missing Summary values

3 participants

@TG1999 @pombredanne @keshav-space