Skip to content

Migrate RetireDotnet to Advisory V2 #2141

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ziadhany merged 6 commits into from
Feb 10, 2026
Merged

Migrate RetireDotnet to Advisory V2 #2141

ziadhany merged 6 commits into from
Feb 10, 2026
+468 −0

Conversation

@ziadhany
Copy link
Collaborator

@ziadhany ziadhany commented Feb 4, 2026 •
edited
Loading

Issue:

Pipeline logs:

Importing data using retiredotnet_importer_v2
INFO 2026-02-10 13:49:23.589691 UTC Pipeline [RetireDotnetImporterPipeline] starting
INFO 2026-02-10 13:49:23.589825 UTC Step [clone] starting
INFO 2026-02-10 13:49:23.589878 UTC Cloning `git+https://github.com/RetireNet/Packages/`
INFO 2026-02-10 13:49:25.263145 UTC Step [clone] completed in 2 seconds
INFO 2026-02-10 13:49:25.263359 UTC Step [collect_and_store_advisories] starting
INFO 2026-02-10 13:49:25.264397 UTC Collecting 20 advisories
INFO 2026-02-10 13:49:25.331742 UTC Progress: 10% (2/20) ETA: 1 seconds
INFO 2026-02-10 13:49:25.523421 UTC Progress: 20% (4/20) ETA: 1 seconds
INFO 2026-02-10 13:49:25.827435 UTC Progress: 30% (6/20) ETA: 1 seconds
INFO 2026-02-10 13:49:26.204369 UTC Progress: 40% (8/20) ETA: 1 seconds
INFO 2026-02-10 13:49:26.618685 UTC Progress: 50% (10/20) ETA: 1 seconds
INFO 2026-02-10 13:49:27.065595 UTC Progress: 60% (12/20) ETA: 1 seconds
INFO 2026-02-10 13:49:27.566992 UTC Progress: 70% (14/20) ETA: 1 seconds
INFO 2026-02-10 13:49:28.161761 UTC Progress: 80% (16/20) ETA: 1 seconds
INFO 2026-02-10 13:49:28.822737 UTC Progress: 90% (18/20)
INFO 2026-02-10 13:49:29.606047 UTC Progress: 100% (20/20)
INFO 2026-02-10 13:49:30.018587 UTC Successfully collected 20 advisories
INFO 2026-02-10 13:49:30.018904 UTC Step [collect_and_store_advisories] completed in 5 seconds
INFO 2026-02-10 13:49:30.018959 UTC Step [clean_downloads] starting
INFO 2026-02-10 13:49:30.019002 UTC Removing cloned repository
INFO 2026-02-10 13:49:30.020713 UTC Step [clean_downloads] completed in 0 seconds
INFO 2026-02-10 13:49:30.020778 UTC Pipeline completed in 6 seconds

Process finished with exit code 0

from vulnerabilities.models import AdvisoryV2
from django.db.models import Count
duplicates = (
    AdvisoryV2.objects
    .values('avid')
    .annotate(count=Count('id'))
    .filter(count__gt=1)
)
len(duplicates)
Out[2]: 0
AdvisoryV2.objects.count()
Out[3]: 20

TG1999
TG1999 reviewed Feb 4, 2026
View reviewed changes
@ziadhany ziadhany requested a review from TG1999 February 4, 2026 15:38
TG1999
TG1999 approved these changes Feb 10, 2026
View reviewed changes
Copy link
Contributor

@TG1999 TG1999 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Minor nit

@ziadhany
Migrate RetireDotnet to Advisory V2
597da64 
Signed-off-by: ziad hany <ziadhany2016@gmail.com>
@ziadhany
Add missing affected_packages
dbd585e 
Signed-off-by: ziad hany <ziadhany2016@gmail.com>
@ziadhany
Update the pipeline to run once
d0a5f8f 
Update advisory_id
Simplify grouped_packages structure

Signed-off-by: ziad hany <ziadhany2016@gmail.com>
@ziadhany
Fix a typo in fixed_version_range
74ffe5e 
Signed-off-by: ziad hany <ziadhany2016@gmail.com>
@ziadhany
Update retiredotnet to use the new AdvisoryDataV2
22fb93d 
Drop duplicates in affected and fixed version range

Signed-off-by: ziad hany <ziadhany2016@gmail.com>
@ziadhany
Fix a comment typo
8afe691 
Signed-off-by: ziad hany <ziadhany2016@gmail.com>
@ziadhany ziadhany merged commit 4a11509 into aboutcode-org:main Feb 10, 2026
5 of 6 checks passed
@ziadhany ziadhany mentioned this pull request Feb 10, 2026
Closed
@ziadhany ziadhany deleted the retiredotnet branch February 10, 2026 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@TG1999 TG1999 TG1999 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ziadhany @TG1999