feat(validate): add command to validate JSON AST against Concerto met… #69
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…amodel and enhance print function with AST validation Add validateAST method to validate Concerto metamodel JSON structures Enhance print function to validate AST structure before converting to CTO Provide detailed error messages for invalid AST structur Signed-off-by: Hussein Saad <hussein.saad2021@gmail.com>
Author
|
hi @DianaLease, could you please review this PR? |
Member
mttrbrts
requested changes
Mar 26, 2025
Member
mttrbrts
left a comment
mttrbrts
left a comment
There was a problem hiding this comment.
Thanks for the contribution! Let's reuse the validation logic that already exists in the MetamodelUtil module, rather than redefining it partially here.
Signed-off-by: Hussein Saad <hussein.saad2021@gmail.com>
mttrbrts
reviewed
Apr 5, 2025
Member
mttrbrts
left a comment
mttrbrts
left a comment
There was a problem hiding this comment.
Thanks for your contribution. Just a few small comments from me.
… AST validation Signed-off-by: Hussein Saad <hussein.saad2021@gmail.com>
Signed-off-by: Hussein Saad <hussein.saad2021@gmail.com>
Signed-off-by: Hussein Saad <hussein.saad2021@gmail.com>
Author
|
hey @mttrbrts, could you take a look at the changes when you have time? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #55
Changes
New Command Addition:
validate-astcommand to the CLI, which validates a JSON syntax tree against the Concerto metamodel.Error Handling Improvements:
printmethod to catch and report JSON parsing errors and invalid AST structures. (lib/commands.js)validateASTmethod. (lib/commands.js)Validation Enhancements:
validateASTmethod in theCommandsclass to validate a Concerto JSON AST. This method checks for the correct structure, required properties. (lib/commands.js)Test Coverage Expansion:
validateASTmethod to cover various scenarios, including valid and invalid models, missing properties, and error handling. (test/cli.js)test/cli.js)Related Issues
Author Checklist
--signoffoption of git commit.mainfromfork:branchname