Fix subtle intra-line deletion tracking bug #270
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
svarlamov
force-pushed
the
fix/ai-line-attr-imara-bugs
branch
from
630482f to
b37053b
Compare
svarlamov
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unrelated to imara_diff migration, but I caught it while working on the migration. Git AI was not properly changing line attribution in the case where a pure deletion was made on a single line, for ex changing a line from
Hello worldto justHellowould leave the original attribution. The root cause of this bug is that the new attribution for the deletion wasn't being saved, because it had no length. Added a new 'tombstone' attribution and tests to make sure Git AI properly attributes such changes in checkpoints.