-
Notifications
You must be signed in to change notification settings - Fork 55
As5600 #798
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Note to self - Do not merge without testing reinitialising the as5600 |
brentru
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@tyeth Requesting two changes
|
As mentioned in the MLX pull request, I believe (not verified 100%) the destructors are not being called, due to the |
|
@tyeth MLX has been fixed and released, is this PR still blocking? |
brentru
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, feedback addressed
Adds the magnetic angle sensor.
Worth noting the device zeros on reset/init.
Not sure my angular calculation from the "scaled" value correctly gives 0-359 which I think is what's expected.
Also didn't have a great magnet for testing, but did see rotation, and returning to approximate expected angle