forked from hiero-ledger/hiero-sdk-python
-
Notifications
You must be signed in to change notification settings - Fork 0
test: add unit tests for crypto_utils (Issue #993) #1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
adityashirsatrao007
wants to merge
6
commits into
main
Choose a base branch
from
test/issue-993-crypto-utils
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
5b91fe5
chore(deps): bump step-security/harden-runner from 2.13.2 to 2.14.0 (…
dependabot[bot] ee3bcab
test: add unit tests for crypto_utils (Issue #993)
adityashirsatrao007 e2b88b5
test: apply copilot suggestions for crypto_utils
adityashirsatrao007 fd13f8a
test: improve coverage with Copilot suggestions
adityashirsatrao007 ebeca54
test: rename to test_crypto_utils.py to match convention
adityashirsatrao007 0fdd761
docs: fix markdown formatting in changelog
adityashirsatrao007 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,88 @@ | ||
| """Unit tests for crypto_utils module.""" | ||
| from cryptography.hazmat.primitives.asymmetric import ec | ||
| import pytest | ||
|
|
||
| from hiero_sdk_python.utils.crypto_utils import ( | ||
| compress_point_unchecked, | ||
| compress_with_cryptography, | ||
| decompress_point, | ||
| keccak256, | ||
| ) | ||
|
|
||
| pytestmark = pytest.mark.unit | ||
|
|
||
|
|
||
| def test_keccak256(): | ||
| """Test keccak256 hashing.""" | ||
| # Known vector: empty string -> c5d2460186f7233c927e7db2dcc703c0e500b653ca82273b7bfad8045d85a470 | ||
| assert keccak256(b"").hex() == "c5d2460186f7233c927e7db2dcc703c0e500b653ca82273b7bfad8045d85a470" | ||
|
|
||
| # "hello" -> 1c8aff950685c2ed4bc3174f3472287b56d9517b9c948127319a09a7a36deac8 | ||
| assert keccak256(b"hello").hex() == "1c8aff950685c2ed4bc3174f3472287b56d9517b9c948127319a09a7a36deac8" | ||
|
|
||
|
Comment on lines
+15
to
+22
|
||
| # "Transfer" -> 461a29a8a7db848c0827103038dd4776114eb182e0717208d0a793574936353d | ||
| assert keccak256(b"Transfer").hex() == "f099cd8bde557814842a3121e8ddfd433a539b8c9f14bf31ebf108d12e6196e9" | ||
|
|
||
|
|
||
| def test_compress_point_unchecked(): | ||
| """Test point compression logic.""" | ||
| # Use cryptography to generate a valid point | ||
| priv = ec.generate_private_key(ec.SECP256K1()) | ||
| pub = priv.public_key() | ||
| nums = pub.public_numbers() | ||
| x = nums.x | ||
| y = nums.y | ||
|
|
||
| compressed = compress_point_unchecked(x, y) | ||
| assert len(compressed) == 33 | ||
|
|
||
| # Verify expected prefix | ||
| expected_prefix = 0x03 if y % 2 else 0x02 | ||
| assert compressed[0] == expected_prefix | ||
| assert int.from_bytes(compressed[1:], "big") == x | ||
|
|
||
|
|
||
| def test_decompress_point(): | ||
| """Test point decompression logic.""" | ||
| priv = ec.generate_private_key(ec.SECP256K1()) | ||
| pub = priv.public_key() | ||
| nums = pub.public_numbers() | ||
|
|
||
| # Create valid compressed point | ||
| compressed = compress_point_unchecked(nums.x, nums.y) | ||
|
|
||
| # Test decompression | ||
| x, y = decompress_point(compressed) | ||
| assert x == nums.x | ||
| assert y == nums.y | ||
|
|
||
| # Test uncompressed 65-byte format (0x04 + x + y) | ||
| uncompressed = b'\x04' + nums.x.to_bytes(32, 'big') + nums.y.to_bytes(32, 'big') | ||
| x2, y2 = decompress_point(uncompressed) | ||
| assert x2 == nums.x | ||
| assert y2 == nums.y | ||
|
|
||
|
Comment on lines
+45
to
+64
|
||
| # Test invalid length | ||
| with pytest.raises(ValueError, match="Not recognized"): | ||
| decompress_point(b'\x04' * 10) | ||
|
|
||
| # Test invalid prefix | ||
| with pytest.raises(ValueError, match="Not recognized"): | ||
| # 0x05 is invalid prefix for 33-byte point | ||
| invalid_point = b'\x05' + nums.x.to_bytes(32, 'big') | ||
| decompress_point(invalid_point) | ||
|
|
||
|
|
||
| def test_compress_with_cryptography(): | ||
| """Test compression using cryptography library.""" | ||
| priv = ec.generate_private_key(ec.SECP256K1()) | ||
| pub = priv.public_key() | ||
| nums = pub.public_numbers() | ||
|
|
||
| # Create uncompressed | ||
| uncompressed = b'\x04' + nums.x.to_bytes(32, 'big') + nums.y.to_bytes(32, 'big') | ||
|
|
||
| compressed_via_lib = compress_with_cryptography(uncompressed) | ||
| compressed_manual = compress_point_unchecked(nums.x, nums.y) | ||
|
|
||
| assert compressed_via_lib == compressed_manual | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing
pytestimport andpytestmark = pytest.mark.unitmarker. All other unit test files in this codebase include these. Add:after the imports and before the first test function.