chore: update testing sheet automation #9411
Conversation
|
Build successful! 🎉 |
|
Build successful! 🎉 |
This reverts commit 55b8ce9.
|
Build successful! 🎉 |
|
Build successful! 🎉 |
|
Build successful! 🎉 |
|
Build successful! 🎉 |
yihuiliao
changed the title
yihuiliao
changed the title
|
Build successful! 🎉 |
| if (labels.size === 0) { | ||
| otherPRs.push(row); | ||
| } else { | ||
| if (labels.has('S2')) { |
There was a problem hiding this comment.
I don't know if you're already considering this, but you can probably auto apply these labels when the "needs localisation" tag is applied as well, just by checking the directories that a change affects
There was a problem hiding this comment.
oh true, that shouldn't be too hard to do
| return title.replace(/\s*\(#\d+\)\s*$/, ''); | ||
| } | ||
|
|
||
| let validLabels = new Set([ |
There was a problem hiding this comment.
can we automate this list? is it all labels? or are some omitted?
There was a problem hiding this comment.
i don't think we want to have all the labels available on our github. it is filtered to some extent because i don't want to include labels like "good first issue" or "ready for review". there are only some labels that are actually "valid". if we automated it by pulling all the labels available on the repo, we would still have to filter it. maybe that would be easier to maintain tho?
|
Build successful! 🎉 |
Labels, labels, labels! In order for the script to produce a meaningful output, we need to add the appropriate labels to each PR, notably which library (S2, RAC, V3) and component the PR belongs to. If there is no valid component label, the script will default to using the PR title as the "Component" column. If the library label is missing, the script will default to "Other".
If a PR does not need testing, we can add the "no testing" label so the script skips the PR.
I've also added the PR title to the last column just to give a bit more context directly on the sheet. That said, I'm sure most of us open the GitHub link anyway so not sure how useful this is but might be good when differentiating between two PR's under the same component.
Probably the most important thing is to add testing instructions since this is the most time consuming part of creating a testing sheet. The script will look for the content under "Test Instructions" in the PR to fill out this column. For those on the team, it is each of our responsibility to add testing instructions to our own PR's. If it doesn't need to be tested during the testing session, we should be adding the "no testing" label.
For contributors, those reviewing should be taking a look at the testing instructions and adding any additional instructions if needed.
✅ Pull Request Checklist:
📝 Test Instructions:
🧢 Your Project: