fix: all node.contains for shadow dom usage #9485
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
snowystinger
commented
Jan 15, 2026
|
|
||
| import {act, within} from '@testing-library/react'; | ||
| import {CheckboxGroupTesterOpts, UserOpts} from './types'; | ||
| import {nodeContains} from '@react-aria/utils'; |
Member
Author
There was a problem hiding this comment.
should we also use this in the test-utils, or should I disable the rule for this package?
Member
There was a problem hiding this comment.
hm i don't think it's really necessary for test-utils. i'd be fine with disabling the rule for this package
5 tasks
|
Build successful! 🎉 |
5 tasks
reidbarber
previously approved these changes
Jan 15, 2026
|
Build successful! 🎉 |
reidbarber
approved these changes
Jan 21, 2026
yihuiliao
approved these changes
Jan 23, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes
Originally from #9369
This is a fully automated PR and should not change the behaviour of anything by default as nodeContains just uses node.contains under the hood unless the shadow dom flag is on.
✅ Pull Request Checklist:
📝 Test Instructions:
🧢 Your Project: