docs: followup for after initial release #9492
Merged
+36
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yihuiliao
commented
Jan 16, 2026
|
Build successful! 🎉 |
reidbarber
reviewed
Jan 16, 2026
| headings.push(...subHeadings); | ||
| } | ||
| } | ||
| let allTags = (page.exports?.tags || page.exports?.keywords as string[]) || []; |
Member
There was a problem hiding this comment.
Should we include page.exports?.relatedPages.map(page => page.title) here? It might be nice to have the hook names accounted for in the docs.
If we do that we probably want to filter out .startsWith('Testing ') so the S2 component testing docs aren't included.
Member
Author
There was a problem hiding this comment.
oh yeah that sounds like a good idea, let me do that
|
Build successful! 🎉 |
reidbarber
reviewed
Jan 16, 2026
reidbarber
approved these changes
Jan 26, 2026
|
Build successful! 🎉 |
devongovett
approved these changes
Jan 26, 2026
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jan 26, 2026
* chore: new docs followup * add headings to search as keywords * fix lint * filter tags * add example to filter
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
|
Build successful! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
apologies for the non-descriptive title but this PR does two things
✅ Pull Request Checklist:
📝 Test Instructions:
🧢 Your Project: