fix: all active element access for shadow dom#9608
Merged
snowystinger merged 8 commits intomainfrom Feb 9, 2026
Merged
Conversation
|
Build successful! 🎉 |
reidbarber
previously approved these changes
Feb 9, 2026
# Conflicts: # packages/@react-aria/numberfield/src/useNumberField.ts # packages/@react-aria/utils/src/useViewportSize.ts # packages/@react-spectrum/menu/src/ContextualHelpTrigger.tsx # packages/@react-spectrum/menu/src/SubmenuTrigger.tsx # packages/@react-spectrum/menu/src/useOverlayPosition.ts
LFDanLu
previously approved these changes
Feb 9, 2026
reidbarber
previously approved these changes
Feb 9, 2026
# Conflicts: # eslint.config.mjs # packages/@react-aria/calendar/src/useRangeCalendar.ts # packages/@react-aria/dialog/src/useDialog.ts # packages/@react-aria/grid/src/useGridCell.ts # packages/@react-aria/gridlist/src/useGridListItem.ts # packages/@react-aria/menu/src/useSubmenuTrigger.ts # packages/@react-aria/overlays/src/useOverlayPosition.ts # packages/@react-aria/selection/src/useSelectableCollection.ts # packages/@react-spectrum/menu/src/ContextualHelpTrigger.tsx # packages/@react-spectrum/menu/src/SubmenuTrigger.tsx # packages/@react-spectrum/s2/src/TableView.tsx # packages/@react-spectrum/table/src/TableViewBase.tsx # packages/dev/eslint-plugin-rsp-rules/index.js # packages/react-aria-components/src/Popover.tsx
reidbarber
approved these changes
Feb 9, 2026
|
Build successful! 🎉 |
LFDanLu
approved these changes
Feb 9, 2026
This was referenced Feb 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes
As part of the series #9551 and #9485
The three of them combined should close out Shadow dom event handling
changes all
document.activeElementtogetActiveElement()which will default to using document.✅ Pull Request Checklist:
📝 Test Instructions:
🧢 Your Project: