Add overlay[local?] to subclasses of TypeModel#268
Merged
jeongsoolee09 merged 1 commit intomainfrom Dec 9, 2025
Merged
Conversation
data-douser
previously approved these changes
Dec 8, 2025
data-douser
reviewed
Dec 8, 2025
Collaborator
data-douser
left a comment
data-douser
left a comment
There was a problem hiding this comment.
These changes alone did not solve the problem when using v2.23.7, as tested in #266 . Perhaps we need to wait for an updated v2.23.7 release, or a new v2.23.8 release, and/or to just apply the overlay[local?] annotation more broadly.
data-douser
dismissed
their stale review
Dismissing my own review to discourage merging until without more testing.
jeongsoolee09
approved these changes
Dec 9, 2025
Contributor
jeongsoolee09
left a comment
jeongsoolee09
left a comment
There was a problem hiding this comment.
There is a breaking change between 2.23.6 and 2.23.7 where all subclasses of ModelInput::TypeModel should be annotated with overlay[local?]. It is recorded in this PR, although the PR itself is closed.
Since these client-side changes are needed anyways, I'll merge it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.