Add cases where JSONModel's content is not visible, Fix UI5 AMD module inheritance, and others #276
Conversation
| - ["Renderer", "Control", "Member[extend].Argument[1].Member[renderer]"] | ||
| - ["Renderer", "sap/ui/core/RenderManager", "Member[extend].Argument[1].Member[renderer]"] | ||
| - ["Renderer", "sap/ui/core/Renderer", "Member[extend].Argument[1]"] | ||
| - ["Renderer", "sap/ui/core/Renderer", "Member[extend].Argument[1]"] # ? |
There was a problem hiding this comment.
maybe add a comment as to why there is a question mark here, or if its not needed anymore, rm
There was a problem hiding this comment.
This turned out to be necessary to cover cases with custom renderers such as xss-indirect-control. Removed the question mark comment in response.
|
|
||
| PropRead getOneTime() { result = this.asSourceNode().getAPropertyRead("OneTime") } | ||
| } | ||
| override string getPathString() { result = "TODO" } |
There was a problem hiding this comment.
is this something we can do in this PR?
There was a problem hiding this comment.
No, it falls outside its scope. Also, JSON models are largely favored over XML models, so we'd wait until we come across major usage of it.
| } | ||
| } | ||
|
|
||
| private class UserDataFromRemoteControlAPISource extends RemoteFlowSource { |
There was a problem hiding this comment.
I think some QL docs on the extensions of RemoteFlowSource in this file would be helpful
| @@ -0,0 +1,12 @@ | |||
| sap.ui.define([ | |||
| "sap/ui/core/UIComponent" | |||
There was a problem hiding this comment.
love the extra test additions, quick question, do we have a better place where these might live though? they arent event bus specific, right, if its odata model testing specifically - maybe we should have a lib test for that? not sure - just thinking out loud!
| } | ||
| } | ||
|
|
||
| class PublishedEventToEventSubscribedEventData extends DataFlow::SharedFlowStep { |
There was a problem hiding this comment.
maybe also add QL doc here
knewbury01
left a comment
knewbury01
left a comment
There was a problem hiding this comment.
nice work @jeongsoolee09 ! left some small initial comments
What This PR Contributes
UI5BindingPath.getNode/0where a binding path to a local model whose contents are not statically visible can still be traced to the model anywaysC's supermodule (some base controller)'s owner component isC's owner component"xinf() { this.f = x }tothis.fing() { this.f }wherefandgare different methods of a same moduleFuture Works