Add ec_private_key and generic_private_key to GENERIC_SECRET_TYPES#13
Merged
Add ec_private_key and generic_private_key to GENERIC_SECRET_TYPES#13
Conversation
Co-authored-by: felickz <1760475+felickz@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Ensure all generic secret types are included in the list
Add ec_private_key and generic_private_key to GENERIC_SECRET_TYPES
Dec 16, 2025
There was a problem hiding this comment.
Pull request overview
This PR adds missing high-precision generic secret types to the GENERIC_SECRET_TYPES constant to ensure comprehensive secret pattern filtering when using the --no-default flag in the secret scanning alerts tool.
Key Changes:
- Added
ec_private_keyandgeneric_private_keytoGENERIC_SECRET_TYPES - Maintained alphabetical ordering for consistency
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
GENERIC_SECRET_TYPESconstant was missing two high-precision generic secret patterns:ec_private_key(Elliptic Curve private keys) andgeneric_private_key(private keys with-----BEGIN PRIVATE KEY-----header).Changes
ec_private_keyandgeneric_private_keyto theGENERIC_SECRET_TYPESlist ingithubapi.pyThis ensures the
--no-defaultflag inlist_secret_scanning_alerts.pycorrectly filters all non-provider secret patterns when querying the GitHub API.Original prompt
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.