Skip to content

Comments

Update MySQL generic secret type identifier to mysql_connection_url#14

Merged
felickz merged 2 commits intomainfrom
copilot/update-mysql-secret-type
Feb 23, 2026
Merged

Update MySQL generic secret type identifier to mysql_connection_url#14
felickz merged 2 commits intomainfrom
copilot/update-mysql-secret-type

Conversation

Copy link
Contributor

Copilot AI commented Feb 23, 2026

GitHub's secret scanning API has renamed the MySQL connection string secret type from mysql_connection_string to mysql_connection_url. Without this update, API calls using the GENERIC_SECRET_TYPES filter would fail to retrieve MySQL connection URL alerts.

Changes

  • githubapi.py: Replace mysql_connection_string with mysql_connection_url in the GENERIC_SECRET_TYPES constant
# Before
GENERIC_SECRET_TYPES = ",".join([
    ...
    "mysql_connection_string",
    ...
])

# After
GENERIC_SECRET_TYPES = ",".join([
    ...
    "mysql_connection_url",
    ...
])
Original prompt

This section details on the original issue you should resolve

<issue_title>[generic-secrets] Update MySQL secret type from mysql_connection_string to mysql_connection_url</issue_title>
<issue_description>## Why this is needed

GitHub's secret scanning documentation has changed the secret type identifier for MySQL connection strings from mysql_connection_string to mysql_connection_url. This change affects API filtering when retrieving generic/non-provider secret scanning alerts.

Required secret type updates

Update the secret type identifier:

  • Old: mysql_connection_string
  • New: mysql_connection_url

All other generic/copilot secret types remain unchanged:

  • ec_private_key
  • generic_private_key
  • http_basic_authentication_header
  • http_bearer_authentication_header
  • mongodb_connection_string
  • openssh_private_key
  • pgp_private_key
  • postgres_connection_string
  • rsa_private_key
  • password

API behavior check

Confirm the API behavior remains:

  • Default secret patterns are returned automatically
  • Generic/copilot patterns require explicit secret_type parameter values

Validate against these endpoints:

Suggested implementation locations

Look for occurrences of mysql_connection_string in:

  • CSV export/reporting logic
  • Configuration files (YAML, JSON, environment variables)
  • Code that constructs secret_type parameter values
  • Documentation and README files
  • Test fixtures or test data
  • Default/constant declarations for secret type lists

Copilot routing

If your repository supports Copilot Workspace or GitHub Copilot agent assignment, please assign this issue to @copilot for automated implementation. Otherwise, maintainers can manually assign to a team member.

AI generated by Generic Secret API Updater

Comments on the Issue (you are @copilot in this section)

  • Fixes advanced-security/.github-private#24

✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

…tion_url

Co-authored-by: felickz <1760475+felickz@users.noreply.github.com>
Copilot AI changed the title [WIP] Update MySQL secret type identifier to mysql_connection_url Update MySQL generic secret type identifier to mysql_connection_url Feb 23, 2026
@felickz felickz marked this pull request as ready for review February 23, 2026 15:53
@felickz felickz requested a review from a team as a code owner February 23, 2026 15:53
@felickz felickz requested review from adrienpessu, Copilot and felickz and removed request for a team February 23, 2026 15:53
Copy link
Contributor

@felickz felickz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:octocat: 👍

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the GitHub secret scanning generic secret type filter to match GitHub’s renamed identifier for MySQL connection strings, ensuring generic secret scanning alert queries continue to return MySQL-related alerts.

Changes:

  • Update the MySQL generic secret type identifier from mysql_connection_string to mysql_connection_url in GENERIC_SECRET_TYPES.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@felickz felickz merged commit 97521a8 into main Feb 23, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants