-
Notifications
You must be signed in to change notification settings - Fork 111
[CLIENT-4055] Refactor cdt_list_operate.c and cdt_map_operate.c #925
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
juliannguyen4
wants to merge
42
commits into
dev
Choose a base branch
from
CLIENT-4055-refactor-cdt_list_operate-and-cdt_map_operate
base: dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
[CLIENT-4055] Refactor cdt_list_operate.c and cdt_map_operate.c #925
juliannguyen4
wants to merge
42
commits into
dev
from
CLIENT-4055-refactor-cdt_list_operate-and-cdt_map_operate
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev #925 +/- ##
==========================================
+ Coverage 83.31% 83.82% +0.51%
==========================================
Files 99 99
Lines 14422 13981 -441
==========================================
- Hits 12016 11720 -296
+ Misses 2406 2261 -145 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
… compiler will optimize these switch statements
This reverts commit 80797cb.
…akes it easier to refactor in the future
…sion code from Python to C failed beforehand...
…= None" This reverts commit 5e73947.
…own scope anyways
…dt_list_operate-and-cdt_map_operate
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to help with maintainability
Currently each of the list operations has a helper function to convert Python parameters into C and add the operation to an
as_operationsobject. This PR consolidates all the helper functions into one to centralize the logic for error handling, converting parameters, and memory cleanup.Extra changes:
cdt_ctx_list_index_createcontextKnown issues that existed beforehand:
The following operations do not validate that the
valuesargument is a list type. There's currently no test code for this case