-
Notifications
You must be signed in to change notification settings - Fork 3
fix: Update asset paths in project.json for testing and UI libraries #101
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Caution Review failedThe pull request is closed. WalkthroughUpdated build asset paths for two libs and bumped/removed various package versions across multiple library manifests; no source-code logic or runtime control-flow changes. Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20–30 minutes
Possibly related PRs
Poem
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
📜 Recent review detailsConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro 📒 Files selected for processing (1)
Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
📜 Review details
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
libs/cli/package.json(1 hunks)
🧰 Additional context used
📓 Path-based instructions (1)
libs/**
⚙️ CodeRabbit configuration file
libs/**: Contains publishable SDK libraries. Review for API correctness, breaking changes, and consistency with docs. When public APIs change, ensure there is a matching docs/draft/docs/** update (not direct edits under docs/docs/**).
Files:
libs/cli/package.json
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
libs/cli/src/commands/create.ts (1)
62-68: Zod v4 force-upgrade silently breaks existing Zod v3 projects without warning.Running
frontmcp createin an existing directory withpackage.jsonwill unconditionally overridezodto^4.0.0(lines 115 and 62-68 after merge at lines 109-117). This is required because@frontmcp/sdk,@frontmcp/plugins, and@frontmcp/adaptersall declarezod: '^4.0.0'as a peerDependency. However, Zod v4 introduces breaking changes from v3 including error API consolidation, ZodError model changes, string validator renames (e.g.,.email(),.uuid()replace older patterns), and function schema API changes. A developer runningfrontmcp createin a project with existing Zod v3 code will experience runtime failures without warning or migration guidance.Either document this Zod v4 requirement prominently in setup/migration guides, add a runtime warning when overriding an existing Zod installation, or provide migration context in the scaffolded project template.
📜 Review details
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (1)
yarn.lockis excluded by!**/yarn.lock,!**/*.lock
📒 Files selected for processing (6)
libs/adapters/package.json(1 hunks)libs/cli/package.json(1 hunks)libs/cli/src/commands/create.ts(2 hunks)libs/sdk/package.json(1 hunks)libs/testing/package.json(1 hunks)package.json(1 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
- libs/cli/package.json
🧰 Additional context used
📓 Path-based instructions (3)
libs/**
⚙️ CodeRabbit configuration file
libs/**: Contains publishable SDK libraries. Review for API correctness, breaking changes, and consistency with docs. When public APIs change, ensure there is a matching docs/draft/docs/** update (not direct edits under docs/docs/**).
Files:
libs/testing/package.jsonlibs/sdk/package.jsonlibs/cli/src/commands/create.tslibs/adapters/package.json
**/*.ts
📄 CodeRabbit inference engine (CLAUDE.md)
**/*.ts: Enable strict TypeScript mode with noanytypes without strong justification - useunknowninstead for generic type defaults
Avoid non-null assertions (!) - use proper error handling and throw specific errors instead
Use specific error classes with MCP error codes instead of generic errors
Use type parameters with constraints instead of unconstrained generics, and preferunknownoveranyfor generic type defaults
Follow the preset pattern for hierarchical configurations across the codebase
Files:
libs/cli/src/commands/create.ts
libs/{sdk,adapters,plugins,cli}/src/**/*.ts
📄 CodeRabbit inference engine (CLAUDE.md)
libs/{sdk,adapters,plugins,cli}/src/**/*.ts: Return strictly typed MCP protocol responses (GetPromptResult, ReadResourceResult, etc.) instead ofunknownforexecute()andread()methods
Validate URIs per RFC 3986 at metadata level using Zod validation with custom refinements
UsegetCapabilities()for dynamic capability exposure instead of hardcoding capabilities in adapters
UsechangeScopeinstead ofscopefor change event properties to avoid confusion with the Scope class
Validate hooks match their entry type and fail fast with InvalidHookFlowError for unsupported flows
Don't mutate rawInput in flows - use state.set() for managing flow state instead
Files:
libs/cli/src/commands/create.ts
🧠 Learnings (2)
📚 Learning: 2025-12-01T00:33:33.644Z
Learnt from: CR
Repo: agentfront/frontmcp PR: 0
File: CLAUDE.md:0-0
Timestamp: 2025-12-01T00:33:33.644Z
Learning: Use FrontMCP's TypeScript-first schema validation framework philosophy - all types should align with MCP protocol definitions
Applied to files:
libs/sdk/package.jsonlibs/adapters/package.json
📚 Learning: 2025-12-01T00:33:33.644Z
Learnt from: CR
Repo: agentfront/frontmcp PR: 0
File: CLAUDE.md:0-0
Timestamp: 2025-12-01T00:33:33.644Z
Learning: Applies to libs/{sdk,adapters,plugins,cli}/src/**/*.ts : Validate URIs per RFC 3986 at metadata level using Zod validation with custom refinements
Applied to files:
libs/cli/src/commands/create.ts
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: build
🔇 Additional comments (3)
package.json (1)
19-30: Dependency bump to MCP SDK 1.24.3 is safe—no breaking changes.
The version includes security fixes, express dependency updates, and HTTP connection handling improvements. Workspace-wide alignment looks intentional.libs/testing/package.json (1)
89-93: MCP SDK version 1.24.3 is a maintenance release with no breaking changes to client behavior.The changelog for 1.24.3 contains only bug fixes and security patches (HTTP connection handling, SSE stream fixes, dependency updates) with no changes to client connection, initialization, or tool-call behavior. E2E test helpers will continue to work without modification.
libs/adapters/package.json (1)
35-42: No action needed — MCP SDK 1.24.3 contains only bug fixes and dependency updates with no breaking TypeScript type changes. The adapter correctly returnsFrontMcpAdapterResponse(properly typed) and imports MCP SDK types likeAuthInfowithout issues.
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.