-
Notifications
You must be signed in to change notification settings - Fork 12
I updated tribute page #2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
📝 WalkthroughWalkthroughThe pull request redesigns a tribute page by restructuring the HTML with improved semantics and accessibility, and completely overhauling the CSS with a card-based layout, gradient background, modern typography, animations, and consolidated responsive design. Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes Poem
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 inconclusive)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
🤖 Fix all issues with AI agents
In `@CSS3/Tribute` Page/index.html:
- Around line 61-63: The anchor element with id="tribute-link" uses
target="_blank" but lacks a rel attribute, which risks reverse-tabnabbing;
update the <a id="tribute-link"
href="https://en.wikipedia.org/wiki/Norman_Borlaug" target="_blank"> element to
include rel="noopener noreferrer" so the external link opens in a new tab safely
and does not expose window.opener.
🧹 Nitpick comments (1)
CSS3/Tribute Page/style.css (1)
118-127: Add aprefers-reduced-motionfallback for animations/transforms.Helps users who disable motion; keep the page accessible.
♿ Suggested addition
`@keyframes` fadeIn { from { opacity: 0; transform: translateY(20px); } to { opacity: 1; transform: translateY(0); } } + +@media (prefers-reduced-motion: reduce) { + * { + animation: none !important; + transition: none !important; + } +}
| <a id="tribute-link" | ||
| href="https://en.wikipedia.org/wiki/Norman_Borlaug" | ||
| target="_blank"> Wikipedia entry | ||
| </a>. | ||
| target="_blank">Wikipedia page</a> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add rel="noopener noreferrer" for security on target="_blank".
This prevents reverse‑tabnabbing and avoids leaking window.opener.
🔒 Suggested fix
- <a id="tribute-link"
- href="https://en.wikipedia.org/wiki/Norman_Borlaug"
- target="_blank">Wikipedia page</a>
+ <a id="tribute-link"
+ href="https://en.wikipedia.org/wiki/Norman_Borlaug"
+ target="_blank"
+ rel="noopener noreferrer">Wikipedia page</a>📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| <a id="tribute-link" | |
| href="https://en.wikipedia.org/wiki/Norman_Borlaug" | |
| target="_blank"> Wikipedia entry | |
| </a>. | |
| target="_blank">Wikipedia page</a> | |
| <a id="tribute-link" | |
| href="https://en.wikipedia.org/wiki/Norman_Borlaug" | |
| target="_blank" | |
| rel="noopener noreferrer">Wikipedia page</a> |
🤖 Prompt for AI Agents
In `@CSS3/Tribute` Page/index.html around lines 61 - 63, The anchor element with
id="tribute-link" uses target="_blank" but lacks a rel attribute, which risks
reverse-tabnabbing; update the <a id="tribute-link"
href="https://en.wikipedia.org/wiki/Norman_Borlaug" target="_blank"> element to
include rel="noopener noreferrer" so the external link opens in a new tab safely
and does not expose window.opener.
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.