Fix build, add lock file, upgrade GitHub Actions#218
Open
thomastoye wants to merge 5 commits intoajv-validator:masterfrom
Open
Fix build, add lock file, upgrade GitHub Actions#218thomastoye wants to merge 5 commits intoajv-validator:masterfrom
thomastoye wants to merge 5 commits intoajv-validator:masterfrom
Conversation
thomastoye
changed the title
ssbarnea
approved these changes
Jan 4, 2023
G-Rath
approved these changes
Jan 8, 2023
Contributor
G-Rath
left a comment
G-Rath
left a comment
There was a problem hiding this comment.
Looks good to me - fwiw I think it's probably worth just typing the errors as any for now rather than casting; ideally we should also have an .npmignore that excludes the package-lock.json
Closed
Member
|
I think recommendation is to use lock files only in applications, but not in the libraries. |
Contributor
|
The general opinion is pretty divided - fwiw I say you should always commit your lockfiles, because you can always have CI workflows for libraries that remove them in order to test that everything works with the latest versions while still retaining the lockfile to prevent issues like this from breaking the general development flow. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi @epoberezkin, I've fixed the build, upgraded GitHub Actions to the latest version, dropped old Node versions and added 16.x and 18.x, and added a lock file to prevent the build from breaking due to in-range update breakage.
Let me know if this looks good. I'd like to add ESM output in a subsequent PR.