Skip to content

Conversation

@mkomel
Copy link

@mkomel mkomel commented Dec 1, 2022

There is no way to explicitly set basic.qos.global when using BasicQos or BasicConsume. SimpleAmqpClient library always sets this to false for RabbitMq broker versions <v3.3.0 and to true for versions >v3.3.0. This made it impossible to set QoS with this library when used with quorum-type queues in RabbitMq >v3.3.0.

This pull request adds overrides to BasicConsume and BasicQos, making it is possible to explicitly set basic.qos.global setting.

This patch fixes #276

@mkomel mkomel changed the title Explicitly set basic.qos.global fixes #276 Explicitly set basic.qos.global Dec 1, 2022
@mkomel
Copy link
Author

mkomel commented Dec 1, 2022

CI environment seems to be broken in this repo.

There are 4 tests failing, none of which is related to the changes within this pull request:
1: [ FAILED ] 4 tests, listed below:
1: [ FAILED ] connecting_test.connect_badvhost
1: [ FAILED ] connecting_test.open_badvhost
1: [ FAILED ] connected_test.channel_publish_full_rejected
1: [ FAILED ] connected_test.basic_message_header_roundtrip

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Prefetch of Quorum queues

1 participant