node-phantom calling twice the phantom create callback#103
Open
apdmatos wants to merge 2 commits intoalexscheelmeyer:masterfrom
Open
node-phantom calling twice the phantom create callback#103apdmatos wants to merge 2 commits intoalexscheelmeyer:masterfrom
apdmatos wants to merge 2 commits intoalexscheelmeyer:masterfrom
Conversation
the callback was executed twice with a phantom process to renew the connection, and the first callback instance is useless with this bug fix, the callback will only be called once and the connection upgrade is transparent to the user
|
@apdmatos , |
Author
|
Have you tried my example that reproduces the bug here: Or as an alternative can you send me the code please? |
wilcr20
approved these changes
Mar 19, 2023
Author
|
wow. Almost 9 years ago. Time flies. Haha |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
Just found a weird behaviour with node-phantom when creating a process.
After calling phantom.create with a callback, after a number of interactions creating and closing pages the callback provided to phantom.create function is executed again.
After digging around with this, I think I found the reason why this happen and here's the fix.
You can find a more detailed description about the bug here: https://github.com/apdmatos/node-phantom-connectionupgrade-bug
And there's a script to reproduce it as well.
For some reason, this does not work with socketio version 1.x.x or higher. So, I've just updated the package.json till someone figure out what is going on with this.
Regards,
André