fix(Flow Types): Fixed Flow typing to allow for omitting options when using the options param#315
Open
FermiDirak wants to merge 1 commit intoalgolia:masterfrom
Open
fix(Flow Types): Fixed Flow typing to allow for omitting options when using the options param#315FermiDirak wants to merge 1 commit intoalgolia:masterfrom
FermiDirak wants to merge 1 commit intoalgolia:masterfrom
Conversation
This comment has been minimized.
This comment has been minimized.
…plit the Options type to OptionParams and Options so that properties can be independently specified in options
Author
|
I'm open to adding tests for this PR |
Contributor
|
@FermiDirak why not just updating the already in place Options type definition (warning: I am new to Flow) |
Author
|
@vvo Flow isn't able to infer default values in a function signature, so when you consume The problem with updating the |
Collaborator
|
To avoid the duplication you could use the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently options are an all or nothing parameter. This means if you want to specify the
tabStop, you must specify every other option if using Flow. This PR splits theOptionstype toOptionParamsandOptionsso that options can be independently specified when using the options param.