Fix for the CV page's date sorting of work history, education, and volunteering #3272
+204
−39
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for relaxed-lollipop-b6bc17 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Collaborator
|
I like your solution, but since this code is repeated in multiple files, maybe it is a good idea to create a plugin for it. Maybe create a new liquid filter that alters the date value, something like _plugins/cache-bust.rb does with urls. What do you think? |
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
Owner
|
@codex, can you look into refactoring changes proposed in this PR to avoid code repetition (consider adding a plugin to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR normalizes partial dates (YYYY, YYYY-MM) to full ISO strings for sorting. It replaces the Liquid date filter with string ops so year-only and year-month values display and sort correctly.
Fixes #3271