add default email for google mcp

[MichaelClifford]

No description provided.

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

[github-actions]

Claude Code Review

Summary

This PR adds a default email configuration for the Google Workspace MCP integration. The change adds the USER_GOOGLE_EMAIL environment variable to the MCP server configuration with a default fallback value.

Issues by Severity

🟡 Major Issues

1. Missing Operator Integration

• Location: .mcp.json:26
• Issue: The new USER_GOOGLE_EMAIL environment variable is added to the MCP configuration, but there's no corresponding change in the operator to pass this environment variable to the session pods.
• Evidence: In components/operator/internal/handlers/sessions.go:1121-1124, only GOOGLE_MCP_CREDENTIALS_DIR, GOOGLE_OAUTH_CLIENT_ID, and GOOGLE_OAUTH_CLIENT_SECRET are set as environment variables for the pod. The USER_GOOGLE_EMAIL variable is not included.
• Impact: The environment variable will not be available in the runner pod, causing the default value user@example.com to always be used, which defeats the purpose of making it configurable.
• Recommendation: Update components/operator/internal/handlers/sessions.go to include the environment variable in the pod spec.

2. Missing Documentation

• Location: N/A
• Issue: No documentation explaining:
  • Why USER_GOOGLE_EMAIL is needed for the Google Workspace MCP integration
  • How administrators should configure this variable
  • What the variable is used for by the workspace-mcp server
• Impact: Unclear operational requirements and configuration guidance
• Recommendation: Update GOOGLE_WORKSPACE_MCP_INTEGRATION.md to document:
  • The purpose of USER_GOOGLE_EMAIL (likely for multi-user scenarios or API quota management)
  • Where to set this variable (operator deployment manifest or environment)
  • Whether it's optional or required

3. Default Value May Be Problematic

• Location: .mcp.json:26
• Issue: The default value user@example.com is a placeholder that may not be valid for the Google Workspace API
• Concern: If the workspace-mcp server requires a valid email (e.g., for impersonation or quota tracking), using user@example.com could cause runtime errors
• Recommendation: Consider one of the following approaches:
  • Make the variable required (no default) to force explicit configuration
  • Use an empty string as default and handle gracefully in the MCP server
  • Document clearly that the default is a placeholder and must be overridden

🔵 Minor Issues

4. No Test Coverage

• Issue: No indication of testing for this change
• Recommendation: Verify:
  • The environment variable propagates correctly to the runner pod
  • The workspace-mcp server accepts and uses the email value
  • Behavior with and without the variable set

5. Inconsistent Naming Pattern

• Location: .mcp.json:26
• Observation: Other Google-related env vars use the GOOGLE_ prefix (GOOGLE_OAUTH_CLIENT_ID, GOOGLE_OAUTH_CLIENT_SECRET, GOOGLE_MCP_CREDENTIALS_DIR), but this one uses USER_GOOGLE_EMAIL
• Suggestion: Consider renaming to GOOGLE_USER_EMAIL or GOOGLE_MCP_USER_EMAIL for consistency (though USER_GOOGLE_EMAIL may be dictated by the workspace-mcp package)

Positive Highlights

✅ Follows bash parameter expansion syntax: The syntax correctly implements default value fallback

✅ Minimal change: Small, focused diff that's easy to review

✅ Proper JSON formatting: Correct comma placement and syntax

Recommendations

Priority 1 (Must Fix Before Merge)

1. Add operator integration - Update components/operator/internal/handlers/sessions.go to pass the USER_GOOGLE_EMAIL environment variable to session pods
2. Test end-to-end - Verify the variable reaches the MCP server and works as expected

Priority 2 (Should Fix Before Merge)

3. Document the change - Update GOOGLE_WORKSPACE_MCP_INTEGRATION.md with configuration guidance
4. Clarify default value strategy - Decide if user@example.com is appropriate or if the variable should be required

Priority 3 (Consider for Future)

5. Add validation - Consider validating email format if it's user-configurable
6. Align naming conventions - Review if USER_GOOGLE_EMAIL follows the workspace-mcp package requirements

Checklist Validation

Reviewing against project standards:

Backend/Operator Standards:

• ❌ Missing operator changes to propagate environment variable
• ⚠️ Security: Email is not sensitive, no redaction needed
• N/A Other backend patterns (no Go code changes)

Documentation Standards:

• ❌ No documentation updates for new configuration variable
• ❌ Missing admin setup instructions

Testing Standards:

• ⚠️ No indication of testing performed

---

Overall Assessment: This PR addresses a configuration need for the Google Workspace MCP integration, but is incomplete without corresponding operator changes. The variable will not be available to the MCP server in its current form. Please address the operator integration and documentation before merging.

---

🔍 View AI decision process (logs available for 90 days)

📋 View memory system files loaded (click to expand)

What Amber Loaded for Code Review

Amber automatically loaded these repository standards from the memory system:

1. CLAUDE.md - Master project instructions, development standards
2. backend-development.md - Go backend, K8s integration patterns
3. frontend-development.md - NextJS, Shadcn UI, React Query patterns
4. security-standards.md - Auth, RBAC, token handling
5. k8s-client-usage.md - User token vs service account patterns
6. error-handling.md - Consistent error patterns
7. react-query-usage.md - Data fetching patterns

Impact: This review used your repository's specific code quality standards, security patterns, and best practices from the memory system (PRs #359, #360) - not just generic code review guidelines.