Skip to content

DimmPlugin collector parsing enhancement #114

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
alexandraBara merged 2 commits into from
Jan 27, 2026
Merged

DimmPlugin collector parsing enhancement #114

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
39497a2
collector parsing enhancement
Jan 27, 2026
c01872e
format structure fix
Jan 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
33 changes: 18 additions & 15 deletions nodescraper/plugins/inband/dimm/dimm_collector.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@
# SOFTWARE.
#
###############################################################################
import re
from typing import Optional

from nodescraper.base import InBandDataCollector
Expand Down Expand Up @@ -97,25 +98,27 @@ def collect_data(
if res.exit_code == 0:
total = 0
topology = {}
size = None
for d in res.stdout.splitlines():
split = d.split()
size = split[2]
key = split[1] + split[2]
if not topology.get(key, None):
topology[key] = 1
else:
topology[key] += 1
num_gb = int(split[1])
total += num_gb
size = ""
dimm_size_pattern = re.compile(r"Size:\s+(\d+)\s+([A-Za-z]+)")
matches = dimm_size_pattern.findall(res.stdout)
if matches:
for match in matches:
size = match[1]
total += int(match[0])
key = match[0] + match[1]
if not topology.get(key, None):
topology[key] = 1
else:
topology[key] += 1
topology["total"] = total
topology["size"] = size
total_gb = topology.pop("total")
size = topology.pop("size")
dimm_str = str(total_gb) + size + " @"
for size, count in topology.items():
dimm_str += f" {count} x {size}"

if total_gb == 0:
dimm_str = "0 GB"
else:
dimm_entries = [f"{v} x {k}" for k, v in topology.items()]
dimm_str = f"{total_gb}{size} @ {' '.join(dimm_entries)}"
if res.exit_code != 0:
self._log_event(
category=EventCategory.OS,
Expand Down