Fix pytest issue #71
Merged
Fix pytest issue #71
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Commit adefa17 fixes a syntax issue in README -- instead of opening a separate PR, I figured I would just add the fix together with this PR. Please let me know if this is not allowed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #61
What I've changed:
netifaces-pluswithifaddr.ifaddr.Reasons for using
ifaddr:netifaces-plusrecommendsifaddr.ifaddris a pure python package.ifaddrprovides RFC4007 scope id as a number, whilenetifaces-plusprovides the scope id as the interface name (on Linux). Therefore we can just use the number (actually, interface number), no need to convert back from interface name to interface number.I've made a small test for comparison, here: https://github.com/wpyoga/python-ifaces-test