Skip to content

Conversation

@wpyoga
Copy link
Contributor

@wpyoga wpyoga commented Dec 12, 2024

This prevents all tests to be cancelled when one test fails.

For example, after the IPv6 scope ID issue is fixed, the automated tests on Python 3.7 and Python 3.8 will fail (because of other reasons). When one test fails, all the other tests are cancelled.

With this patch, the other tests will not be cancelled.

@wpyoga
Copy link
Contributor Author

wpyoga commented Dec 12, 2024

Tests on Python 3.7 and 3.8 fail because the ipaddress library on those older Python versions don't support IPv6 scope ID.

Would it be a good idea to drop support for those versions? Or, maybe disable IPv6 for those versions? Python 3.8 is already past EOL at this point: https://devguide.python.org/versions/

@andreikop andreikop merged commit da1e8b5 into andreikop:master Dec 13, 2024
4 of 6 checks passed
@wpyoga wpyoga deleted the ghactions-disable-fail-fast branch December 13, 2024 12:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants