Axt 2026 01 14 release branch #2465
Conversation
It is currently planned to release a new standlone androidx.test.monitor artifact. This change explictly adds monitor to the gradle deps, so this new version can be tested while using the stable released versions of other artifacts. PiperOrigin-RevId: 856301565
Summary of ChangesHello @brettchabot, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request focuses on preparing the AndroidX Test project for a release branch, as indicated by the title 'Axt 2026 01 14 release branch'. The primary changes involve a strategic rollback of several core AndroidX Test component versions from alpha to more stable or older releases, ensuring a robust foundation for the upcoming release. Additionally, the 'monitor' library has been consistently integrated across various test modules and build configurations, and the internal Maven repository definition has been streamlined. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request appears to be preparing for a release by updating dependency versions. However, there are a few concerns.
Most critically, the BUILD file change removes almost all artifacts from the axt_m2repository, which is likely an error from an automation script and could break Bazel builds.
Additionally, there's an inconsistency in the version updates in build_extensions/axt_versions.bzl, where most versions are downgraded, but one remains an alpha version.
Finally, for better maintainability, I've made a suggestion to sort the libraries in the Gradle version catalog template alphabetically.
Please review these points, especially the critical issue in the BUILD file.
| "//services:test_services_maven_artifact", | ||
| "//services/storage/java/androidx/test/services/storage:test_storage_maven_artifact", | ||
| ], | ||
| srcs = ["//runner/monitor/java/androidx/test:monitor_maven_artifact"], |
There was a problem hiding this comment.
The srcs list for the axt_m2repository has been reduced to a single artifact. This repository is intended to contain all AndroidX Test artifacts for Bazel-based testing. Removing almost all artifacts will likely break builds that depend on this. This change seems to be a result of an error in the release automation script (tools/release/validate_and_propagate_versions.sh). Please verify that this change is intentional. If not, the list of artifacts should be restored.
| RUNNER_VERSION = "1.7.0" | ||
| RULES_VERSION = "1.7.0" | ||
| MONITOR_VERSION = "1.9.0-alpha01" | ||
| ESPRESSO_VERSION = "3.8.0-alpha01" | ||
| CORE_VERSION = "1.8.0-alpha01" | ||
| ESPRESSO_DEVICE_VERSION = "1.2.0-alpha01" | ||
| ANDROIDX_JUNIT_VERSION = "1.4.0-alpha01" | ||
| ANDROIDX_TRUTH_VERSION = "1.8.0-alpha01" | ||
| ORCHESTRATOR_VERSION = "1.7.0-alpha01" | ||
| SERVICES_VERSION = "1.7.0-alpha01" | ||
| ESPRESSO_VERSION = "3.7.0" | ||
| CORE_VERSION = "1.7.0" | ||
| ESPRESSO_DEVICE_VERSION = "1.1.0" | ||
| ANDROIDX_JUNIT_VERSION = "1.3.0" | ||
| ANDROIDX_TRUTH_VERSION = "1.7.0" | ||
| ORCHESTRATOR_VERSION = "1.6.1" | ||
| SERVICES_VERSION = "1.6.0" |
There was a problem hiding this comment.
There's an inconsistency in the version updates. Most versions are being reverted to older, stable releases (e.g., RUNNER_VERSION from 1.8.0-alpha01 to 1.7.0), but MONITOR_VERSION remains at 1.9.0-alpha01. Could you clarify if this is intentional? If all versions are meant to be for a specific release, they should probably be consistent.
| versionCatalogs { | ||
| libs { | ||
| library('core', 'androidx.test:core:{CORE_VERSION}') | ||
| library('monitor', 'androidx.test:monitor:{MONITOR_VERSION}') |
There was a problem hiding this comment.
For better maintainability and readability, it's a good practice to keep the library definitions in the version catalog sorted alphabetically by their alias. Please consider reordering all library definitions within the libs block alphabetically. Since settings.gradle is auto-generated from this template, this is the correct place to apply the change.
2 participants
Overview
Proposed Changes