-
Notifications
You must be signed in to change notification settings - Fork 5.3k
Keep one CODEOWNERS #1596
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Keep one CODEOWNERS #1596
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Summary of Changes
Hello @yrezgui, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request streamlines the project's code ownership configuration by removing a redundant CODEOWNERS file. The intent is to consolidate all code ownership definitions into a single, authoritative file, simplifying maintenance and clarity for future contributions.
Highlights
- Code Ownership Consolidation: The
.github/CODEOWNERSfile, which previously assigned ownership of all files to@android/compose-devrel, has been removed. This action is part of an effort to maintain only oneCODEOWNERSfile across the repository, simplifying code ownership management.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request simplifies repository configuration by consolidating two CODEOWNERS files into one. The change involves deleting the .github/CODEOWNERS file, making the root CODEOWNERS file the single source of truth.
My review focuses on the maintainability implications of this consolidation strategy. The change results in shifting code ownership from a team handle to a list of individuals. I have added a comment recommending that the more robust and maintainable team-based ownership model be retained.
| @@ -1 +0,0 @@ | |||
| * @android/compose-devrel | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While consolidating to a single CODEOWNERS file is a good practice, this change replaces team-based ownership (@android/compose-devrel) with ownership by individuals, as defined in the root CODEOWNERS file.
Using a team for code ownership is generally more maintainable and robust than listing individuals. It avoids the need to update the file when team members change and is more resilient to people being unavailable or leaving the project.
To improve maintainability, I recommend retaining team-based ownership. Please consider updating the remaining CODEOWNERS file to specify the @android/compose-devrel team instead of individuals.
|
I'm skipping one check as the build GitHub action expected but blocked as waiting |
There's currently two different CODEOWNERS. We're keeping only one