Skip to content

Add matcher and kokoro setup#190

Merged
cy245 merged 2 commits intoandroid:wasmfrom
danjkim:wasm
Feb 3, 2026
Merged

Add matcher and kokoro setup#190
cy245 merged 2 commits intoandroid:wasmfrom
danjkim:wasm

Conversation

@danjkim
Copy link

@danjkim danjkim commented Jan 31, 2026

Adding rust wasm generation logic to the CredentialProvider repo. The logic will match the incoming request with the registered export entries by looking at credential types. Kokoro build system will trigger the build of the wasm repo and store the newly generated wasm into GCS compliant with BCID_L1.

@gemini-code-assist
Copy link

Summary of Changes

Hello @danjkim, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request integrates Rust WebAssembly generation capabilities into the CredentialProvider repository. It establishes the foundational logic for matching incoming requests against credential types and sets up a robust Kokoro build pipeline. This pipeline automates the compilation of the Rust WASM module and ensures its proper storage in GCS, streamlining the development and deployment of credential-based services.

Highlights

  • Rust WASM Logic: Introduces the core Rust WebAssembly generation logic within the CredentialProvider repository.
  • Request Matching: Implements a mechanism to match incoming requests with registered export entries based on credential types.
  • Kokoro Build Integration: Sets up the Kokoro build system to automate the compilation of the Rust WASM project.
  • Artifact Storage: Configures Kokoro to store the newly generated WASM artifacts into Google Cloud Storage, adhering to BCID_L1 standards.
  • License Generation: Adds a utility script to automatically vendor Rust dependencies and aggregate their third-party license information.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces Kokoro build configuration and associated scripts for generating a Rust WASM module. The changes are a good step towards automating the build process. However, I've identified several issues that need to be addressed:

  • Script Robustness: The generate_license.sh script lacks error handling (set -e) and suppresses error messages, which could lead to silent failures and difficult debugging.
  • Path Inconsistencies: There are critical inconsistencies in file paths within the Kokoro configuration (continuous.cfg) and the build script (kokoro_build.sh). The strip_prefix and mv command paths do not seem to align with the project structure, which will likely cause the build to fail.
  • Missing Build Script: The main build logic is in a ./build.sh script which is called by kokoro_build.sh but is not included in this pull request. This makes it impossible to fully review the end-to-end build process.

My detailed comments provide specific suggestions to fix these issues. Please address the critical path issues and improve the script's robustness.

@cy245
Copy link
Contributor

cy245 commented Feb 2, 2026

Can you resolve comments if you addressed them? Also can you update the sample README to describe what this contains?

@danjkim danjkim force-pushed the wasm branch 2 times, most recently from 7853de6 to d6c327a Compare February 3, 2026 04:11
@danjkim
Copy link
Author

danjkim commented Feb 3, 2026

Can you resolve comments if you addressed them? Also can you update the sample README to describe what this contains?

Done!

@cy245
Copy link
Contributor

cy245 commented Feb 3, 2026

Can you resolve comments if you addressed them? Also can you update the sample README to describe what this contains?

Done!

Thanks! Can you also do the parent README https://github.com/android/identity-samples/blob/main/README.md?

Adding rust wasm generation logic to the CredentialProvider repo. The logic will match the incoming request with the registered export entries by looking at credential types. Kokoro build system will trigger the build of the wasm repo and store the newly generated wasm into GCS compliant with BCID_L1.

Add matcher source code for credential exchange

Add source code for credential exchange matcher. Create a build script that runs the Makefile.

fixing github suggestions

add README

fix spacing

update README
@danjkim
Copy link
Author

danjkim commented Feb 3, 2026

Thanks! Can you also do the parent README https://github.com/android/identity-samples/blob/main/README.md?

Done!

@cy245 cy245 merged commit f51dd7a into android:wasm Feb 3, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants