Conversation
Summary of ChangesHello @danjkim, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request integrates Rust WebAssembly generation capabilities into the CredentialProvider repository. It establishes the foundational logic for matching incoming requests against credential types and sets up a robust Kokoro build pipeline. This pipeline automates the compilation of the Rust WASM module and ensures its proper storage in GCS, streamlining the development and deployment of credential-based services. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request introduces Kokoro build configuration and associated scripts for generating a Rust WASM module. The changes are a good step towards automating the build process. However, I've identified several issues that need to be addressed:
- Script Robustness: The
generate_license.shscript lacks error handling (set -e) and suppresses error messages, which could lead to silent failures and difficult debugging. - Path Inconsistencies: There are critical inconsistencies in file paths within the Kokoro configuration (
continuous.cfg) and the build script (kokoro_build.sh). Thestrip_prefixandmvcommand paths do not seem to align with the project structure, which will likely cause the build to fail. - Missing Build Script: The main build logic is in a
./build.shscript which is called bykokoro_build.shbut is not included in this pull request. This makes it impossible to fully review the end-to-end build process.
My detailed comments provide specific suggestions to fix these issues. Please address the critical path issues and improve the script's robustness.
CredentialProvider/wasm/credential_transfer/generate_license.sh
Outdated
Show resolved
Hide resolved
|
Can you resolve comments if you addressed them? Also can you update the sample README to describe what this contains? |
7853de6 to
d6c327a
Compare
Done! |
Thanks! Can you also do the parent README https://github.com/android/identity-samples/blob/main/README.md? |
Adding rust wasm generation logic to the CredentialProvider repo. The logic will match the incoming request with the registered export entries by looking at credential types. Kokoro build system will trigger the build of the wasm repo and store the newly generated wasm into GCS compliant with BCID_L1. Add matcher source code for credential exchange Add source code for credential exchange matcher. Create a build script that runs the Makefile. fixing github suggestions add README fix spacing update README
Done! |
Adding rust wasm generation logic to the CredentialProvider repo. The logic will match the incoming request with the registered export entries by looking at credential types. Kokoro build system will trigger the build of the wasm repo and store the newly generated wasm into GCS compliant with BCID_L1.