Make custom column's children not restricted by column's height#112
Make custom column's children not restricted by column's height#112hrach wants to merge 1 commit intoandroid:mainfrom
Conversation
|
@hrach thanks for your PR. Could you please provide more info why you think this is needed? Since it's a simple code snippet, we just want the incoming parent constraints to be used as they are in this case |
For containers, it is hardly wanted to impose incoming constraints on its children. "normal" What's more, as cited, the text mentions it ("without the minHeight constraints") but doesn't do it, which may mislead the reader even more. |
|
@hrach ah I see. My interpretation was that, since it's a simple code snippet, "without the minHeight constraints" means we won't change any constraints, not even minHeight. But your interpretation is opposite, more matching the expected Column behaviour. In that case, could you please move this to line 158 (you've made a change in the wrong snippet) and leave a comment above, explaining why you're overriding the child items constraints? Thanks 😊 |
This fixes the layout and makes the example fit the description: