Open
Conversation
Author
|
@andywer What do you think of this PR? Anything I can do to make it more palatable? |
Owner
|
Great stuff! Thanks, @pkerpedjiev! Unfortunately I didn't find the time to review any earlier. Could you also provide a test case (we have a few tests that build using webpack and then run the result)? I haven't tested it yet. Are you actively using this approach? |
Author
|
Hey, sorry, I'm a little delayed in writing a test. While I dawdle on that, just wanted to say that I am actively using that approach and so far it's worked very well. Here's a link to the config file if you (or anybody else that comes across this) is interested: https://github.com/higlass/higlass-pileup/blob/master/webpack.config.js |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update the blob worker docs with an example webpack config file.
Shouldn't be necessary to do multiple webpack runs with this configuration.