added support to spawn threads from electron asar bundles#469
Open
biw wants to merge 1 commit intoandywer:masterfrom
Open
added support to spawn threads from electron asar bundles#469biw wants to merge 1 commit intoandywer:masterfrom
biw wants to merge 1 commit intoandywer:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey @andywer, thanks for the great repo. As described in #425, electron now supports spawning threads from asar bundles. This PR adds support for asar bundles.
In order to keep the default behavior the same (no breaking changes), I added an opt-in value
electronAsarUnpackedto the worker constructor, which when set tofalsepasses the raw value toNativeWorker.For anyone reading this (other than @andywer) who needs this behavior before the PR is merged in, here is a patch (for use with patch-package):