fix(@schematics/angular): add missing imports for lifecycle hooks in jasmine-vitest migration#31918
Merged
clydin merged 1 commit intoangular:mainfrom Nov 24, 2025
Merged
Conversation
Collaborator
|
These functions are globally available. |
Member
Author
|
If you don't use vitest globals, tests won't compile without importing them, so I think |
clydin
reviewed
Nov 24, 2025
packages/schematics/angular/refactor/jasmine-vitest/test-file-transformer.ts
Outdated
Show resolved
Hide resolved
…jasmine-vitest migration
9e7e7ee to
71e0e7a
Compare
clydin
approved these changes
Nov 24, 2025
Member
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check to confirm your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
When using
ng g refactor-jasmine-vitest --add-importsthe lifecycle hooks of vitest are not importedDoes this PR introduce a breaking change?
Other information