Skip to content

Conversation

@jase88
Copy link
Contributor

@jase88 jase88 commented Nov 25, 2025

PR Checklist

Please check to confirm your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

What is the current behavior?

Issue Number: #31941

What is the new behavior?

Within the refactor-jasmine-vitest schematic jasmine.createSpyObj calls without base name are transformed correctly.

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@jase88 jase88 force-pushed the fix/31941-createSpyObj-without-baseName branch from d69a83c to 07b8e9d Compare November 25, 2025 13:25
@jase88 jase88 changed the title fix(jasmine-spy): handle createSpyObj without base name and update tests fix(@schematics/angular): handle createSpyObj without base name on refactor-jasmine-vitest Nov 25, 2025
@jase88 jase88 force-pushed the fix/31941-createSpyObj-without-baseName branch from 07b8e9d to d0a457a Compare November 25, 2025 13:29
@clydin clydin added target: patch This PR is targeted for the next patch release action: merge The PR is ready for merge by the caretaker labels Nov 25, 2025
@clydin clydin linked an issue Nov 25, 2025 that may be closed by this pull request
1 task
@clydin
Copy link
Member

clydin commented Nov 25, 2025

Thank you for the contribution.

@clydin clydin merged commit 5ef8b99 into angular:main Nov 25, 2025
37 checks passed
@clydin
Copy link
Member

clydin commented Nov 25, 2025

This PR was merged into the repository. The changes were merged into the following branches:

@jase88 jase88 deleted the fix/31941-createSpyObj-without-baseName branch November 25, 2025 16:12
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Dec 26, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: merge The PR is ready for merge by the caretaker area: @schematics/angular target: patch This PR is targeted for the next patch release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

refactor-jasmine-vitest: createSpyObj without base name not handled

2 participants