refactor(multiple): eliminate usages of any type batch #4 #32394
Conversation
jamOne-
force-pushed
the
eliminate-any-4
branch
from
93361d4 to
ee47476
Compare
jamOne-
requested review from
adolgachev and
ok7sai
and removed request for
a team
|
@andrewseguin PTAL |
|
@andrewseguin apparently narrowing the |
| /** Updates the tooltip class */ | ||
| private _setTooltipClass(tooltipClass: string | string[] | Set<string> | {[key: string]: any}) { | ||
| private _setTooltipClass( | ||
| tooltipClass: string | string[] | Set<string> | {[key: string]: unknown}, |
There was a problem hiding this comment.
I believe the intent is to have the final type be similar to Angular's class binding where there's a map of strings to booleans. Let's use boolean instead of unknown
There was a problem hiding this comment.
boolean would not be the most accurate, as the type in the docs is Record<string, any>.
IIUC the meaning of any is that we allow for actually any type, because we'll covert it to boolean.
Nonetheless I believe unknown is a safer choice here, as it would still allow for the flexibility of passing actually anything, with the difference that our code cannot use this value with other contexts (different than unknown or any) without an explicit cast.
jamOne-
force-pushed
the
eliminate-any-4
branch
from
122137a to
b50f12c
Compare
2 participants
Most important:
MatTableDataSource: RequireTto extend fromobject, so the filtering works correctly.Other changes should be harmless.