feat: add validation that ratings didn't change #196
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crisbeto
changed the title
Adds a `ratingHash` on the environment that is generated from the current set of ratings. In addition, includes an `expectedRatingHash` field on the environment config which can be used to verify that an environment has a specific hash before it is executed. This is useful to ensure that the ratings stay stable between runs and `web-codegen-scorer` releases.
Formats the release scripts to match the rest of the repo. Also sets `stable` as the first selection in the release script.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a
ratingHashon the environment that is generated from the current set of ratings. In addition, includes anexpectedRatingHashfield on the environment config which can be used to verify that an environment has a specific hash before it is executed. This is useful to ensure that the ratings stay stable between runs andweb-codegen-scorerreleases.