fix(permission): resolve path specificity using longest matching rule#14540
Open
ventsislav-georgiev wants to merge 1 commit intoanomalyco:devfrom
Open
fix(permission): resolve path specificity using longest matching rule#14540ventsislav-georgiev wants to merge 1 commit intoanomalyco:devfrom
ventsislav-georgiev wants to merge 1 commit intoanomalyco:devfrom
Conversation
Contributor
|
Thanks for your contribution! This PR doesn't have a linked issue. All PRs must reference an existing issue. Please:
See CONTRIBUTING.md for details. |
Contributor
|
Thanks for updating your PR! It now meets our contributing guidelines. 👍 |
4617db2 to
5ea5848
Compare
5ea5848 to
27a1e1b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Closes #13646, #13872, #11272 (maybe others)
Type of change
What does this PR do?
PermissionNext.asknow evaluates each requested pattern in two forms: the original input and, when relative, a worktree-resolved absolute path. It then picks the decision from the most specific matched rule (longest matched pattern).This fixes cases where generic wildcard rules could beat path-scoped rules only because a tool supplied a relative path.
How did you verify your code works?
bun test test/permission/next.test.tsbun test test/permission-task.test.tsAdded regression tests in
packages/opencode/test/permission/next.test.ts:Screenshots / recordings
Not a UI change.
Checklist
If you do not follow this template your PR will be automatically rejected.