fix(config): sort plugin paths for deterministic load order#14547
Open
kevinWangSheng wants to merge 1 commit intoanomalyco:devfrom
Open
fix(config): sort plugin paths for deterministic load order#14547kevinWangSheng wants to merge 1 commit intoanomalyco:devfrom
kevinWangSheng wants to merge 1 commit intoanomalyco:devfrom
Conversation
Glob.scan() returns results in filesystem (readdir) order, which is nondeterministic and can change after file recreation or FS migration. Sort discovered plugin paths so users can control execution order with filename prefixes (e.g. 00_safety.ts, 50_helper.ts). Fixes anomalyco#14492 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
github-actions
bot
added
needs:compliance
Contributor
|
Thanks for updating your PR! It now meets our contributing guidelines. 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Closes #14492
Type of change
What does this PR do?
Sorts plugin file paths in
loadPlugin()after glob scanning.Glob.scan()returns results in readdir order which is nondeterministic. Adding.sort()makes load order alphabetical so users can control hook execution order via filename prefixes (e.g.00_safety.ts,50_helper.ts).How did you verify your code works?
Reviewed the single-line change.
Array.sort()on file URL strings produces stable alphabetical order. All CI checks pass.Screenshots / recordings
N/A - no UI change.
Checklist