fix(config): log warning when plugin path resolution fails#14556
Open
kevinWangSheng wants to merge 4 commits intoanomalyco:devfrom
Open
fix(config): log warning when plugin path resolution fails#14556kevinWangSheng wants to merge 4 commits intoanomalyco:devfrom
kevinWangSheng wants to merge 4 commits intoanomalyco:devfrom
Conversation
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
The session list command supports --format json for machine-readable output, but the models command only supported plain text. This adds a --format option with choices "text" (default) and "json" to bring consistency across CLI commands and enable scripting use cases. Closes anomalyco#14550 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
When import.meta.resolve fails for a plugin path, the error was completely swallowed by an empty catch block. This adds a warning log so users can diagnose plugin loading issues. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
The `model` object already contains an `id` field, so spreading it after the explicit `id` property triggers TS2783. Move the spread before the explicit properties so our composite id takes precedence. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Contributor
|
Thanks for updating your PR! It now meets our contributing guidelines. 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Closes #11701
Type of change
What does this PR do?
Adds a
log.warncall in the previously emptycatch (err) {}block whenimport.meta.resolvefails for a plugin path. Without this, misconfigured plugin paths fail silently with zero feedback.How did you verify your code works?
Single-line change using the existing
loginstance. Follows the same pattern as line 296 in the same file.Screenshots / recordings
N/A - no UI change.
Checklist